Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(623)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1131573006: ARM64: Enable shorten-64-to-32 warning (Closed)

Created:
5 years, 7 months ago by martyn.capewell
Modified:
5 years, 7 months ago
Reviewers:
Benedikt Meurer, ulan
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

ARM64: Enable shorten-64-to-32 warning Enable clang's shorten-64-to-32 warning flag on ARM64, and fix the warnings that arise. BUG= Committed: https://crrev.com/cdc43bc5fd02fff2905e2e28a79054d0d1eee3ea Cr-Commit-Position: refs/heads/master@{#28412}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+282 lines, -229 lines) Patch
M build/standalone.gypi View 1 chunk +1 line, -3 lines 0 comments Download
M src/arm64/assembler-arm64.h View 5 chunks +7 lines, -6 lines 0 comments Download
M src/arm64/assembler-arm64.cc View 19 chunks +49 lines, -31 lines 0 comments Download
M src/arm64/assembler-arm64-inl.h View 2 chunks +6 lines, -5 lines 0 comments Download
M src/arm64/code-stubs-arm64.h View 1 chunk +4 lines, -2 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/disasm-arm64.cc View 5 chunks +11 lines, -10 lines 0 comments Download
M src/arm64/full-codegen-arm64.cc View 3 chunks +6 lines, -9 lines 0 comments Download
M src/arm64/instructions-arm64.h View 4 chunks +6 lines, -8 lines 0 comments Download
M src/arm64/instructions-arm64.cc View 6 chunks +14 lines, -11 lines 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 2 chunks +6 lines, -10 lines 0 comments Download
M src/arm64/macro-assembler-arm64.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/arm64/macro-assembler-arm64.cc View 6 chunks +11 lines, -9 lines 0 comments Download
M src/arm64/simulator-arm64.h View 3 chunks +4 lines, -13 lines 0 comments Download
M src/arm64/simulator-arm64.cc View 18 chunks +72 lines, -84 lines 0 comments Download
M src/arm64/utils-arm64.h View 1 chunk +43 lines, -0 lines 0 comments Download
M src/arm64/utils-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/base/bits.h View 1 chunk +11 lines, -0 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/compiler/arm64/instruction-selector-arm64.cc View 9 chunks +16 lines, -14 lines 0 comments Download
M src/frames.cc View 1 chunk +1 line, -1 line 0 comments Download
M test/cctest/test-code-stubs-arm64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M test/cctest/test-fuzz-arm64.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M test/cctest/test-utils-arm64.h View 1 chunk +3 lines, -3 lines 0 comments Download
M test/unittests/compiler/arm64/instruction-selector-arm64-unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
martyn.capewell
5 years, 7 months ago (2015-05-14 18:42:07 UTC) #2
Benedikt Meurer
LGTM, thanks a lot.
5 years, 7 months ago (2015-05-15 04:32:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1131573006/1
5 years, 7 months ago (2015-05-15 04:32:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 05:13:21 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-15 05:13:39 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/cdc43bc5fd02fff2905e2e28a79054d0d1eee3ea
Cr-Commit-Position: refs/heads/master@{#28412}

Powered by Google App Engine
This is Rietveld 408576698