[strong] Disallow implicit conversions for comparison

[strong] Disallow implicit conversions for comparison

Implements the strong mode proposal's restrictions on implicit conversions
for the binary >, >=, <, and <= operators.

BUG=v8:3956
LOG=N

Committed: https://crrev.com/03ef40b46cfebdd10b31e2baf1d5d10d4c8c5cce
Cr-Commit-Position: refs/heads/master@{#28370}

[conradw, 2015-05-08 11:53:26]

conradw@chromium.org changed reviewers:
+ rossberg@chromium.org

[conradw, 2015-05-08 11:53:28]

PTAL

[rossberg, 2015-05-08 13:54:36]

https://codereview.chromium.org/1130283002/diff/80001/src/code-stubs.h
File src/code-stubs.h (right):

https://codereview.chromium.org/1130283002/diff/80001/src/code-stubs.h#newcod...
src/code-stubs.h:1472: CompareICStub(Isolate* isolate, Token::Value op, bool
strong,
Use LanguageMode here

https://codereview.chromium.org/1130283002/diff/80001/src/ic/ic.h
File src/ic/ic.h (right):

https://codereview.chromium.org/1130283002/diff/80001/src/ic/ic.h#newcode707
src/ic/ic.h:707: bool strong);
LanguageMode?

https://codereview.chromium.org/1130283002/diff/80001/src/ic/ic.h#newcode716
src/ic/ic.h:716: bool strong);
Same here

https://codereview.chromium.org/1130283002/diff/80001/src/runtime.js
File src/runtime.js (right):

https://codereview.chromium.org/1130283002/diff/80001/src/runtime.js#newcode21
src/runtime.js:21: var COMPARE;
Declare COMPARE_STRONG here

https://codereview.chromium.org/1130283002/diff/80001/src/runtime.js#newcode206
src/runtime.js:206: //Strong mode COMPARE throws if an implicit conversion would
be performed
Nit: space

[conradw, 2015-05-08 14:08:21]

https://codereview.chromium.org/1130283002/diff/80001/src/code-stubs.h
File src/code-stubs.h (right):

https://codereview.chromium.org/1130283002/diff/80001/src/code-stubs.h#newcod...
src/code-stubs.h:1472: CompareICStub(Isolate* isolate, Token::Value op, bool
strong,
On 2015/05/08 13:54:36, rossberg wrote:
> Use LanguageMode here

After offline discussion, keeping bool for now. Will change binop to follow this
pattern later if no other objections.

https://codereview.chromium.org/1130283002/diff/80001/src/ic/ic.h
File src/ic/ic.h (right):

https://codereview.chromium.org/1130283002/diff/80001/src/ic/ic.h#newcode707
src/ic/ic.h:707: bool strong);
On 2015/05/08 13:54:36, rossberg wrote:
> LanguageMode?

See above.

https://codereview.chromium.org/1130283002/diff/80001/src/ic/ic.h#newcode716
src/ic/ic.h:716: bool strong);
On 2015/05/08 13:54:36, rossberg wrote:
> Same here

See above.

https://codereview.chromium.org/1130283002/diff/80001/src/runtime.js
File src/runtime.js (right):

https://codereview.chromium.org/1130283002/diff/80001/src/runtime.js#newcode21
src/runtime.js:21: var COMPARE;
On 2015/05/08 13:54:36, rossberg wrote:
> Declare COMPARE_STRONG here

Done.

https://codereview.chromium.org/1130283002/diff/80001/src/runtime.js#newcode206
src/runtime.js:206: //Strong mode COMPARE throws if an implicit conversion would
be performed
On 2015/05/08 13:54:36, rossberg wrote:
> Nit: space

Done.

[rossberg, 2015-05-12 14:34:11]

lgtm

[conradw, 2015-05-12 14:43:21]

The CQ bit was checked by conradw@chromium.org

[commit-bot: I haz the power, 2015-05-12 14:43:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1130283002/120001

[commit-bot: I haz the power, 2015-05-12 15:24:02]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2015-05-12 15:24:11]

Patchset 7 (id:??) landed as
https://crrev.com/03ef40b46cfebdd10b31e2baf1d5d10d4c8c5cce
Cr-Commit-Position: refs/heads/master@{#28370}