src/hydrogen.cc - Issue 1130283002: [strong] Disallow implicit conversions for comparison

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/hydrogen.cc

Issue 1130283002: [strong] Disallow implicit conversions for comparison (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: cl feedback Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/hydrogen.cc

diff --git a/src/hydrogen.cc b/src/hydrogen.cc

index 77890f6fbf8f3aca926641450cbe885d14277ecd..7bfff3ea641f79d157e450f311cfc0388d248c52 100644

--- a/src/hydrogen.cc

+++ b/src/hydrogen.cc

@@ -11209,7 +11209,8 @@ HControlInstruction* HOptimizedGraphBuilder::BuildCompareInstruction(

return result;

} else {

if (combined_rep.IsTagged() || combined_rep.IsNone()) {

- HCompareGeneric* result = Add<HCompareGeneric>(left, right, op);

+ HCompareGeneric* result =

+ Add<HCompareGeneric>(left, right, op, function_language_mode());

result->set_observed_input_representation(1, left_rep);

result->set_observed_input_representation(2, right_rep);

if (result->HasObservableSideEffects()) {

« no previous file with comments | « src/compiler/js-typed-lowering.cc ('k') | src/ia32/code-stubs-ia32.cc » ('j') | no next file with comments »