Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Side by Side Diff: src/code-factory.cc

Issue 1130283002: [strong] Disallow implicit conversions for comparison (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: cl feedback Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/code-factory.h ('k') | src/code-stubs.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 the V8 project authors. All rights reserved. 1 // Copyright 2014 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/v8.h" 5 #include "src/v8.h"
6 6
7 #include "src/bootstrapper.h" 7 #include "src/bootstrapper.h"
8 #include "src/code-factory.h" 8 #include "src/code-factory.h"
9 #include "src/ic/ic.h" 9 #include "src/ic/ic.h"
10 10
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 Callable CodeFactory::KeyedStoreICInOptimizedCode( 98 Callable CodeFactory::KeyedStoreICInOptimizedCode(
99 Isolate* isolate, LanguageMode language_mode, 99 Isolate* isolate, LanguageMode language_mode,
100 InlineCacheState initialization_state) { 100 InlineCacheState initialization_state) {
101 return Callable(KeyedStoreIC::initialize_stub(isolate, language_mode, 101 return Callable(KeyedStoreIC::initialize_stub(isolate, language_mode,
102 initialization_state), 102 initialization_state),
103 StoreDescriptor(isolate)); 103 StoreDescriptor(isolate));
104 } 104 }
105 105
106 106
107 // static 107 // static
108 Callable CodeFactory::CompareIC(Isolate* isolate, Token::Value op) { 108 Callable CodeFactory::CompareIC(Isolate* isolate, Token::Value op,
109 Handle<Code> code = CompareIC::GetUninitialized(isolate, op); 109 LanguageMode language_mode) {
110 Handle<Code> code =
111 CompareIC::GetUninitialized(isolate, op, is_strong(language_mode));
110 return Callable(code, CompareDescriptor(isolate)); 112 return Callable(code, CompareDescriptor(isolate));
111 } 113 }
112 114
113 115
114 // static 116 // static
115 Callable CodeFactory::BinaryOpIC(Isolate* isolate, Token::Value op, 117 Callable CodeFactory::BinaryOpIC(Isolate* isolate, Token::Value op,
116 LanguageMode language_mode) { 118 LanguageMode language_mode) {
117 BinaryOpICStub stub(isolate, op, language_mode); 119 BinaryOpICStub stub(isolate, op, language_mode);
118 return Callable(stub.GetCode(), stub.GetCallInterfaceDescriptor()); 120 return Callable(stub.GetCode(), stub.GetCallInterfaceDescriptor());
119 } 121 }
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
183 185
184 // static 186 // static
185 Callable CodeFactory::CallFunction(Isolate* isolate, int argc, 187 Callable CodeFactory::CallFunction(Isolate* isolate, int argc,
186 CallFunctionFlags flags) { 188 CallFunctionFlags flags) {
187 CallFunctionStub stub(isolate, argc, flags); 189 CallFunctionStub stub(isolate, argc, flags);
188 return Callable(stub.GetCode(), stub.GetCallInterfaceDescriptor()); 190 return Callable(stub.GetCode(), stub.GetCallInterfaceDescriptor());
189 } 191 }
190 192
191 } // namespace internal 193 } // namespace internal
192 } // namespace v8 194 } // namespace v8
OLDNEW
« no previous file with comments | « src/code-factory.h ('k') | src/code-stubs.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698