Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Side by Side Diff: src/ic/ic.h

Issue 1130283002: [strong] Disallow implicit conversions for comparison (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: cl feedback Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/ia32/lithium-ia32.h ('k') | src/ic/ic.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef V8_IC_H_ 5 #ifndef V8_IC_H_
6 #define V8_IC_H_ 6 #define V8_IC_H_
7 7
8 #include "src/ic/ic-state.h" 8 #include "src/ic/ic-state.h"
9 #include "src/macro-assembler.h" 9 #include "src/macro-assembler.h"
10 10
(...skipping 685 matching lines...) Expand 10 before | Expand all | Expand 10 after
696 CompareIC(Isolate* isolate, Token::Value op) 696 CompareIC(Isolate* isolate, Token::Value op)
697 : IC(EXTRA_CALL_FRAME, isolate), op_(op) {} 697 : IC(EXTRA_CALL_FRAME, isolate), op_(op) {}
698 698
699 // Update the inline cache for the given operands. 699 // Update the inline cache for the given operands.
700 Code* UpdateCaches(Handle<Object> x, Handle<Object> y); 700 Code* UpdateCaches(Handle<Object> x, Handle<Object> y);
701 701
702 // Helper function for computing the condition for a compare operation. 702 // Helper function for computing the condition for a compare operation.
703 static Condition ComputeCondition(Token::Value op); 703 static Condition ComputeCondition(Token::Value op);
704 704
705 // Factory method for getting an uninitialized compare stub. 705 // Factory method for getting an uninitialized compare stub.
706 static Handle<Code> GetUninitialized(Isolate* isolate, Token::Value op); 706 static Handle<Code> GetUninitialized(Isolate* isolate, Token::Value op,
707 bool strong);
707 708
708 private: 709 private:
709 static bool HasInlinedSmiCode(Address address); 710 static bool HasInlinedSmiCode(Address address);
710 711
711 bool strict() const { return op_ == Token::EQ_STRICT; } 712 bool strict() const { return op_ == Token::EQ_STRICT; }
712 Condition GetCondition() const { return ComputeCondition(op_); } 713 Condition GetCondition() const { return ComputeCondition(op_); }
713 714
714 static Code* GetRawUninitialized(Isolate* isolate, Token::Value op); 715 static Code* GetRawUninitialized(Isolate* isolate, Token::Value op,
716 bool strong);
715 717
716 static void Clear(Isolate* isolate, Address address, Code* target, 718 static void Clear(Isolate* isolate, Address address, Code* target,
717 ConstantPoolArray* constant_pool); 719 ConstantPoolArray* constant_pool);
718 720
719 Token::Value op_; 721 Token::Value op_;
720 722
721 friend class IC; 723 friend class IC;
722 }; 724 };
723 725
724 726
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
766 768
767 // Support functions for interceptor handlers. 769 // Support functions for interceptor handlers.
768 DECLARE_RUNTIME_FUNCTION(LoadPropertyWithInterceptorOnly); 770 DECLARE_RUNTIME_FUNCTION(LoadPropertyWithInterceptorOnly);
769 DECLARE_RUNTIME_FUNCTION(LoadPropertyWithInterceptor); 771 DECLARE_RUNTIME_FUNCTION(LoadPropertyWithInterceptor);
770 DECLARE_RUNTIME_FUNCTION(LoadElementWithInterceptor); 772 DECLARE_RUNTIME_FUNCTION(LoadElementWithInterceptor);
771 DECLARE_RUNTIME_FUNCTION(StorePropertyWithInterceptor); 773 DECLARE_RUNTIME_FUNCTION(StorePropertyWithInterceptor);
772 } 774 }
773 } // namespace v8::internal 775 } // namespace v8::internal
774 776
775 #endif // V8_IC_H_ 777 #endif // V8_IC_H_
OLDNEW
« no previous file with comments | « src/ia32/lithium-ia32.h ('k') | src/ic/ic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698