Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Unified Diff: src/code-factory.cc

Issue 1130283002: [strong] Disallow implicit conversions for comparison (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: cl feedback Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/code-factory.h ('k') | src/code-stubs.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-factory.cc
diff --git a/src/code-factory.cc b/src/code-factory.cc
index 30448d87338bc3d635cd55b9134f3d8381caba8d..8e244604c2e3f19dc91e69e6f69645920f761a3d 100644
--- a/src/code-factory.cc
+++ b/src/code-factory.cc
@@ -105,8 +105,10 @@ Callable CodeFactory::KeyedStoreICInOptimizedCode(
// static
-Callable CodeFactory::CompareIC(Isolate* isolate, Token::Value op) {
- Handle<Code> code = CompareIC::GetUninitialized(isolate, op);
+Callable CodeFactory::CompareIC(Isolate* isolate, Token::Value op,
+ LanguageMode language_mode) {
+ Handle<Code> code =
+ CompareIC::GetUninitialized(isolate, op, is_strong(language_mode));
return Callable(code, CompareDescriptor(isolate));
}
« no previous file with comments | « src/code-factory.h ('k') | src/code-stubs.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698