src/x64/lithium-x64.h - Issue 1130283002: [strong] Disallow implicit conversions for comparison

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/lithium-x64.h

Issue 1130283002: [strong] Disallow implicit conversions for comparison (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: cl feedback Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/x64/lithium-x64.h

diff --git a/src/x64/lithium-x64.h b/src/x64/lithium-x64.h

index b7f2ab9b018cf5587c2dfaa4360492a54693d1a9..0b0a3f6be694d190997d2c3c04f94e042aabc1ac 100644

--- a/src/x64/lithium-x64.h

+++ b/src/x64/lithium-x64.h

@@ -1173,6 +1173,8 @@ class LCmpT final : public LTemplateInstruction<1, 3, 0> {

DECLARE_CONCRETE_INSTRUCTION(CmpT, "cmp-t")

DECLARE_HYDROGEN_ACCESSOR(CompareGeneric)

+ LanguageMode language_mode() { return hydrogen()->language_mode(); }

Token::Value op() const { return hydrogen()->token(); }

};

« no previous file with comments | « src/x64/lithium-codegen-x64.cc ('k') | src/x87/code-stubs-x87.cc » ('j') | no next file with comments »