Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(210)

Issue 11280290: events: Change gesture-event handler in EventHandler to not return any values. (Closed)

Created:
8 years ago by sadrul
Modified:
8 years ago
CC:
chromium-reviews, asanka, sadrul, yusukes+watch_chromium.org, ben+watch_chromium.org, tfarina, jam, Randy Smith (Not in Mondays), dcheng, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, James Su
Visibility:
Public.

Description

events: Change gesture-event handler in EventHandler to not return any values. The EventHandler overriddes should mark the event as having been processed (Event::SetHandled) when the event triggered an action, or stop the propagation of the event (Event::StopPropagation) as appropriate (when the handler destroyed the event-target, for example). BUG=163618 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=170890

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+401 lines, -464 lines) Patch
M ash/drag_drop/drag_drop_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/drag_drop/drag_drop_controller.cc View 3 chunks +10 lines, -6 lines 0 comments Download
M ash/drag_drop/drag_drop_controller_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/launcher/launcher_button.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/launcher/launcher_button.cc View 2 chunks +7 lines, -4 lines 0 comments Download
M ash/launcher/launcher_tooltip_manager.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/launcher/launcher_tooltip_manager.cc View 1 chunk +1 line, -4 lines 0 comments Download
M ash/launcher/launcher_tooltip_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/launcher/launcher_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/launcher/launcher_view.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ash/system/status_area_widget_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/status_area_widget_delegate.cc View 1 chunk +4 lines, -5 lines 0 comments Download
M ash/system/tray/tray_notification_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_notification_view.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M ash/system/tray/tray_views.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray/tray_views.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M ash/wm/activation_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/activation_controller.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/wm/app_list_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/app_list_controller.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/wm/system_gesture_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/system_gesture_event_filter.cc View 4 chunks +13 lines, -13 lines 0 comments Download
M ash/wm/toplevel_window_event_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/toplevel_window_event_handler.cc View 5 chunks +13 lines, -12 lines 0 comments Download
M ash/wm/user_activity_detector.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/user_activity_detector.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/wm/user_activity_detector_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ash/wm/workspace/frame_maximize_button.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/frame_maximize_button.cc View 3 chunks +10 lines, -6 lines 0 comments Download
M ash/wm/workspace/workspace_event_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/workspace/workspace_event_handler.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/browser_action_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/browser_action_view.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/download/download_item_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/download/download_item_view.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/immersive_mode_controller.h View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/immersive_mode_controller.cc View 2 chunks +0 lines, -17 lines 0 comments Download
M chrome/browser/ui/views/location_bar/ev_bubble_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/ev_bubble_view.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_decoration_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_decoration_view.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/location_bar/location_icon_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_icon_view.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/location_bar/script_bubble_icon_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/script_bubble_icon_view.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/location_bar/star_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/star_view.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/location_bar/zoom_bubble_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/zoom_bubble_view.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/location_bar/zoom_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/zoom_view.cc View 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_popup_contents_view.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab.cc View 3 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/tabs/tab_strip.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 2 chunks +5 lines, -7 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/browser/web_contents/web_contents_view_aura.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M ui/app_list/app_list_item_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/app_list_item_view.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M ui/app_list/contents_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/app_list/contents_view.cc View 2 chunks +10 lines, -8 lines 0 comments Download
M ui/aura/demo/demo_main.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M ui/aura/gestures/gesture_recognizer_unittest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ui/aura/root_window_unittest.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M ui/aura/test/test_event_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/aura/test/test_event_handler.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/aura/test/test_window_delegate.h View 1 chunk +0 lines, -6 lines 0 comments Download
M ui/aura/test/test_window_delegate.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M ui/aura/window_unittest.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M ui/base/events/event.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/base/events/event_dispatcher_unittest.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M ui/base/events/event_handler.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/events/event_handler.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ui/base/events/event_target.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/events/event_target.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/message_center/message_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/message_center/message_view.cc View 1 chunk +10 lines, -9 lines 0 comments Download
M ui/views/color_chooser/color_chooser_view.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/views/controls/button/custom_button.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/custom_button.cc View 2 chunks +9 lines, -6 lines 0 comments Download
M ui/views/controls/button/menu_button.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/button/menu_button.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M ui/views/controls/combobox/native_combobox_views.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/combobox/native_combobox_views.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M ui/views/controls/link.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/link.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/views/controls/menu/menu_controller.h View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/controls/menu/menu_controller.cc View 2 chunks +11 lines, -9 lines 0 comments Download
M ui/views/controls/menu/menu_host_root_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/menu_host_root_view.cc View 1 chunk +6 lines, -6 lines 0 comments Download
M ui/views/controls/menu/submenu_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/menu/submenu_view.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M ui/views/controls/scroll_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/scroll_view.cc View 2 chunks +4 lines, -7 lines 0 comments Download
M ui/views/controls/scrollbar/base_scroll_bar.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/scrollbar/base_scroll_bar.cc View 4 chunks +13 lines, -10 lines 0 comments Download
M ui/views/controls/scrollbar/native_scroll_bar.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/scrollbar/native_scroll_bar.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M ui/views/controls/slide_out_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/slide_out_view.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M ui/views/controls/slider.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/slider.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M ui/views/controls/textfield/native_textfield_views.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/textfield/native_textfield_views.cc View 2 chunks +11 lines, -8 lines 0 comments Download
M ui/views/controls/tree/tree_view_views.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/controls/tree/tree_view_views.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/views/corewm/compound_event_filter.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/corewm/compound_event_filter.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M ui/views/corewm/compound_event_filter_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/corewm/focus_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/corewm/focus_controller.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ui/views/view.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ui/views/view.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M ui/views/view_unittest.cc View 5 chunks +8 lines, -10 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_activation_client.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_activation_client.cc View 1 chunk +1 line, -3 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/desktop_aura/desktop_native_widget_aura.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ui/views/widget/native_widget_aura.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/native_widget_aura.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/views/widget/native_widget_aura_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ui/views/widget/native_widget_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/root_view.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/root_view.cc View 5 chunks +27 lines, -21 lines 0 comments Download
M ui/views/widget/widget.h View 1 chunk +1 line, -1 line 0 comments Download
M ui/views/widget/widget.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M ui/views/widget/widget_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
sadrul
8 years ago (2012-12-04 03:04:13 UTC) #1
Ben Goodger (Google)
8 years ago (2012-12-04 03:12:06 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698