chrome/browser/ui/views/location_bar/location_icon_view.cc - Issue 11280290: events: Change gesture-event handler in EventHandler to not return any values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/location_bar/location_icon_view.cc

Issue 11280290: events: Change gesture-event handler in EventHandler to not return any values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/location_bar/location_icon_view.h ('k') | chrome/browser/ui/views/location_bar/script_bubble_icon_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/location_bar/location_icon_view.cc

diff --git a/chrome/browser/ui/views/location_bar/location_icon_view.cc b/chrome/browser/ui/views/location_bar/location_icon_view.cc

index e9b4fdaf9daec4a51a8956fd295147d6f527df20..d4986c55cdac1577b70ff0459cb98710b071878a 100644

--- a/chrome/browser/ui/views/location_bar/location_icon_view.cc

+++ b/chrome/browser/ui/views/location_bar/location_icon_view.cc

@@ -27,12 +27,11 @@ void LocationIconView::OnMouseReleased(const ui::MouseEvent& event) {

page_info_helper_.ProcessEvent(event);

}

-ui::EventResult LocationIconView::OnGestureEvent(ui::GestureEvent* event) {

+void LocationIconView::OnGestureEvent(ui::GestureEvent* event) {

if (event->type() == ui::ET_GESTURE_TAP) {

page_info_helper_.ProcessEvent(*event);

- return ui::ER_CONSUMED;

+ event->SetHandled();

}

- return ui::ER_UNHANDLED;

}

int LocationIconView::GetBuiltInHorizontalPadding() const {