Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(733)

Unified Diff: chrome/browser/ui/views/location_bar/star_view.cc

Issue 11280290: events: Change gesture-event handler in EventHandler to not return any values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/location_bar/star_view.cc
diff --git a/chrome/browser/ui/views/location_bar/star_view.cc b/chrome/browser/ui/views/location_bar/star_view.cc
index 8f65c1a35aab5c2a84d44ca536e4f955162c2737..72814b857caecba4fa5cb08c00e75e8d9cb5a1d2 100644
--- a/chrome/browser/ui/views/location_bar/star_view.cc
+++ b/chrome/browser/ui/views/location_bar/star_view.cc
@@ -80,13 +80,12 @@ bool StarView::OnKeyPressed(const ui::KeyEvent& event) {
return false;
}
-ui::EventResult StarView::OnGestureEvent(ui::GestureEvent* event) {
+void StarView::OnGestureEvent(ui::GestureEvent* event) {
if (event->type() == ui::ET_GESTURE_TAP) {
UMA_HISTOGRAM_ENUMERATION("Bookmarks.EntryPoint",
bookmark_utils::ENTRY_POINT_STAR_GESTURE,
bookmark_utils::ENTRY_POINT_LIMIT);
command_updater_->ExecuteCommand(IDC_BOOKMARK_PAGE_FROM_STAR);
- return ui::ER_CONSUMED;
+ event->SetHandled();
}
- return ui::ER_UNHANDLED;
}
« no previous file with comments | « chrome/browser/ui/views/location_bar/star_view.h ('k') | chrome/browser/ui/views/location_bar/zoom_bubble_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698