Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1162)

Unified Diff: ui/views/controls/combobox/native_combobox_views.cc

Issue 11280290: events: Change gesture-event handler in EventHandler to not return any values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/views/controls/combobox/native_combobox_views.h ('k') | ui/views/controls/link.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/views/controls/combobox/native_combobox_views.cc
diff --git a/ui/views/controls/combobox/native_combobox_views.cc b/ui/views/controls/combobox/native_combobox_views.cc
index 9f67153904b122b656be83d4856e484ec53a8181..8148e285e430232fef558f1b7e413717c06c4297 100644
--- a/ui/views/controls/combobox/native_combobox_views.cc
+++ b/ui/views/controls/combobox/native_combobox_views.cc
@@ -161,13 +161,14 @@ void NativeComboboxViews::OnBlur() {
/////////////////////////////////////////////////////////////////
// NativeComboboxViews, ui::EventHandler overrides:
-ui::EventResult NativeComboboxViews::OnGestureEvent(ui::GestureEvent* gesture) {
+void NativeComboboxViews::OnGestureEvent(ui::GestureEvent* gesture) {
if (gesture->type() == ui::ET_GESTURE_TAP) {
UpdateFromModel();
ShowDropDownMenu();
- return ui::ER_CONSUMED;
+ gesture->StopPropagation();
+ return;
}
- return View::OnGestureEvent(gesture);
+ View::OnGestureEvent(gesture);
}
/////////////////////////////////////////////////////////////////
« no previous file with comments | « ui/views/controls/combobox/native_combobox_views.h ('k') | ui/views/controls/link.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698