Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(409)

Side by Side Diff: chrome/browser/ui/views/location_bar/ev_bubble_view.cc

Issue 11280290: events: Change gesture-event handler in EventHandler to not return any values. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/location_bar/ev_bubble_view.h" 5 #include "chrome/browser/ui/views/location_bar/ev_bubble_view.h"
6 6
7 EVBubbleView::EVBubbleView(const int background_images[], 7 EVBubbleView::EVBubbleView(const int background_images[],
8 int contained_image, 8 int contained_image,
9 SkColor color, 9 SkColor color,
10 LocationBarView* location_bar) 10 LocationBarView* location_bar)
11 : IconLabelBubbleView(background_images, contained_image, color), 11 : IconLabelBubbleView(background_images, contained_image, color),
12 ALLOW_THIS_IN_INITIALIZER_LIST(page_info_helper_(this, location_bar)) { 12 ALLOW_THIS_IN_INITIALIZER_LIST(page_info_helper_(this, location_bar)) {
13 SetElideInMiddle(true); 13 SetElideInMiddle(true);
14 } 14 }
15 15
16 EVBubbleView::~EVBubbleView() { 16 EVBubbleView::~EVBubbleView() {
17 } 17 }
18 18
19 bool EVBubbleView::OnMousePressed(const ui::MouseEvent& event) { 19 bool EVBubbleView::OnMousePressed(const ui::MouseEvent& event) {
20 // We want to show the dialog on mouse release; that is the standard behavior 20 // We want to show the dialog on mouse release; that is the standard behavior
21 // for buttons. 21 // for buttons.
22 return true; 22 return true;
23 } 23 }
24 24
25 void EVBubbleView::OnMouseReleased(const ui::MouseEvent& event) { 25 void EVBubbleView::OnMouseReleased(const ui::MouseEvent& event) {
26 page_info_helper_.ProcessEvent(event); 26 page_info_helper_.ProcessEvent(event);
27 } 27 }
28 28
29 ui::EventResult EVBubbleView::OnGestureEvent(ui::GestureEvent* event) { 29 void EVBubbleView::OnGestureEvent(ui::GestureEvent* event) {
30 if (event->type() == ui::ET_GESTURE_TAP) { 30 if (event->type() == ui::ET_GESTURE_TAP) {
31 page_info_helper_.ProcessEvent(*event); 31 page_info_helper_.ProcessEvent(*event);
32 return ui::ER_CONSUMED; 32 event->SetHandled();
33 } 33 }
34 return ui::ER_UNHANDLED;
35 } 34 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698