Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Issue 11275113: Remove most remaining references to IntRect and FloatRect. (Closed)

Created:
8 years, 1 month ago by danakj
Modified:
8 years, 1 month ago
Reviewers:
enne (OOO)
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Remove most remaining references to IntRect and FloatRect. The remaining uses are: - Dealing with the output of Region::rects() which gives a vector of WebCore::IntRects. - Using FloatRect::isExpressibleAsIntRect. Covered by existing tests; no new behaviour. BUG=147395 R=enne Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=165542

Patch Set 1 #

Patch Set 2 : Extra header removed #

Patch Set 3 : Fix compositor bindings #

Unified diffs Side-by-side diffs Delta from patch set Stats (+462 lines, -405 lines) Patch
M cc/content_layer_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M cc/damage_tracker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/debug_rect_history.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/delegated_renderer_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/direct_renderer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/direct_renderer.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M cc/float_quad_unittest.cc View 3 chunks +3 lines, -2 lines 0 comments Download
M cc/geometry_binding.h View 2 chunks +4 lines, -2 lines 0 comments Download
M cc/geometry_binding.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M cc/gl_renderer.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/gl_renderer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layer.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layer_impl.h View 2 chunks +2 lines, -1 line 0 comments Download
M cc/layer_impl.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M cc/layer_impl_unittest.cc View 5 chunks +23 lines, -23 lines 0 comments Download
M cc/layer_sorter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layer_sorter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layer_tiling_data.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layer_tiling_data.cc View 2 chunks +3 lines, -1 line 0 comments Download
M cc/layer_tree_host.h View 2 chunks +1 line, -2 lines 0 comments Download
M cc/layer_tree_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layer_tree_host_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/layer_tree_host_impl.cc View 1 2 chunks +17 lines, -21 lines 0 comments Download
M cc/layer_tree_host_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layer_tree_host_unittest.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M cc/layer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/math_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/occlusion_tracker.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/occlusion_tracker.cc View 13 chunks +18 lines, -19 lines 0 comments Download
M cc/occlusion_tracker_unittest.cc View 64 chunks +209 lines, -209 lines 0 comments Download
M cc/overdraw_metrics.h View 3 chunks +8 lines, -5 lines 0 comments Download
M cc/overdraw_metrics.cc View 5 chunks +7 lines, -7 lines 0 comments Download
M cc/page_scale_animation.h View 3 chunks +5 lines, -4 lines 0 comments Download
M cc/page_scale_animation.cc View 3 chunks +15 lines, -9 lines 0 comments Download
M cc/quad_culler.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M cc/render_pass.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/render_pass.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/render_surface_unittest.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M cc/scrollbar_layer_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/scrollbar_layer_impl.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M cc/solid_color_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/solid_color_layer_impl_unittest.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M cc/stubs/Region.h View 2 chunks +33 lines, -0 lines 0 comments Download
M cc/stubs/float_size.h View 2 chunks +8 lines, -0 lines 0 comments Download
M cc/stubs/int_size.h View 2 chunks +8 lines, -0 lines 0 comments Download
M cc/test/layer_test_common.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M cc/test/mock_quad_culler.h View 1 chunk +0 lines, -1 line 0 comments Download
M cc/texture_layer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/tiled_layer.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M cc/tiled_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/tiled_layer_unittest.cc View 16 chunks +16 lines, -16 lines 0 comments Download
M webkit/compositor_bindings/web_layer_tree_view_impl.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
danakj
The patch is pretty much all search and replace/delete. The only mindful bit was in ...
8 years, 1 month ago (2012-11-01 22:03:37 UTC) #1
enne (OOO)
8 years, 1 month ago (2012-11-01 22:59:19 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698