Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Issue 11230011: Make hasNext a getter instead of a method. (Closed)

Created:
8 years, 2 months ago by floitsch
Modified:
8 years, 2 months ago
CC:
reviews_dartlang.org, Mads Ager (google)
Visibility:
Public.

Description

Make hasNext a getter instead of a method. Committed: https://code.google.com/p/dart/source/detail?r=14015

Patch Set 1 #

Total comments: 4

Patch Set 2 : Rebase #

Patch Set 3 : Reupload due to error #

Patch Set 4 : Remove unused variable. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+249 lines, -165 lines) Patch
M lib/compiler/implementation/js_backend/constant_emitter.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/lib/coreimpl_patch.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/compiler/implementation/lib/interceptors.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/lib/js_helper.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M lib/compiler/implementation/lib/string_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/resolution/members.dart View 1 1 chunk +7 lines, -2 lines 0 comments Download
M lib/compiler/implementation/scanner/byte_strings.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/scanner/token.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/compiler/implementation/ssa/builder.dart View 1 2 3 4 chunks +10 lines, -5 lines 0 comments Download
M lib/compiler/implementation/string_validator.dart View 1 3 chunks +6 lines, -6 lines 0 comments Download
M lib/compiler/implementation/tree/dartstring.dart View 5 chunks +7 lines, -7 lines 0 comments Download
M lib/compiler/implementation/types/concrete_types_inferrer.dart View 1 3 chunks +4 lines, -4 lines 0 comments Download
M lib/compiler/implementation/util/link_implementation.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/core/collection.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/core/iterator.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/core/sequences.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/coreimpl/collections.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/coreimpl/hash_map_set.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M lib/coreimpl/queue.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/html/dart2js/html_dart2js.dart View 5 chunks +6 lines, -6 lines 0 comments Download
M lib/html/dartium/html_dartium.dart View 5 chunks +6 lines, -6 lines 0 comments Download
M lib/html/src/_Collections.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/html/src/_ListIterators.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M lib/utf/utf16.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/utf/utf32.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/utf/utf8.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M lib/utf/utf_core.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M pkg/dartdoc/lib/mirrors_util.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart View 1 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/unittest/core_matchers.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/unittest/mock.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/array.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/lib/byte_array.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/lib/string_base.dart View 1 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/intrinsifier.h View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intrinsifier_arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/intrinsifier_ia32.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/intrinsifier_x64.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/parser.cc View 1 1 chunk +2 lines, -3 lines 0 comments Download
M samples/ui_lib/util/CollectionUtils.dart View 3 chunks +6 lines, -6 lines 0 comments Download
M tests/co19/co19-compiler.status View 1 1 chunk +20 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2dart.status View 1 1 chunk +18 lines, -0 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 1 chunk +19 lines, -0 lines 0 comments Download
M tests/co19/co19-runtime.status View 1 1 chunk +18 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/code_motion_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/compiler_helper.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/gvn_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/identity_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/compiler/dart2js/mock_compiler.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/pretty_parameter_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/compiler/dart2js_extra/for_in_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/list_iterators_test.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M tests/corelib/queue_iterator_test.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M tests/corelib/reg_exp5_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/corelib/reg_exp_all_matches_test.dart View 1 chunk +9 lines, -9 lines 0 comments Download
M tests/corelib/reg_exp_start_end_test.dart View 1 chunk +1 line, -1 line 0 comments Download
tests/corelib/set_iterator_test.dart View 1 7 chunks +7 lines, -7 lines 0 comments Download
M tests/corelib/string_pattern_test.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M tests/standalone/io/http_server_early_client_close_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/standalone/io/test_runner_exit_code_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/apidoc/mdn/extract.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/pub/utils.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M utils/template/utils.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M utils/tests/pub/test_pub.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/string_encoding/utf16_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M utils/tests/string_encoding/utf32_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
floitsch
@cshapiro: please verify the changes to the VM. I will file co19 bugs before submitting. ...
8 years, 2 months ago (2012-10-19 19:40:54 UTC) #1
cshapiro
vm changes lgtm
8 years, 2 months ago (2012-10-20 03:30:47 UTC) #2
Lasse Reichstein Nielsen
LGTM on the non-VM changes. https://codereview.chromium.org/11230011/diff/1/lib/compiler/implementation/ssa/builder.dart File lib/compiler/implementation/ssa/builder.dart (right): https://codereview.chromium.org/11230011/diff/1/lib/compiler/implementation/ssa/builder.dart#newcode3433 lib/compiler/implementation/ssa/builder.dart:3433: Element staticInterceptor = null; ...
8 years, 2 months ago (2012-10-20 11:22:42 UTC) #3
Mads Ager (google)
LGTM https://codereview.chromium.org/11230011/diff/1/lib/compiler/implementation/string_validator.dart File lib/compiler/implementation/string_validator.dart (right): https://codereview.chromium.org/11230011/diff/1/lib/compiler/implementation/string_validator.dart#newcode61 lib/compiler/implementation/string_validator.dart:61: if (source.hasNext && identical(source.next(), quoteChar) && source.hasNext) { ...
8 years, 2 months ago (2012-10-22 08:12:06 UTC) #4
floitsch
8 years, 2 months ago (2012-10-24 13:02:47 UTC) #5
https://codereview.chromium.org/11230011/diff/1/lib/compiler/implementation/s...
File lib/compiler/implementation/ssa/builder.dart (right):

https://codereview.chromium.org/11230011/diff/1/lib/compiler/implementation/s...
lib/compiler/implementation/ssa/builder.dart:3433: Element staticInterceptor =
null;
On 2012/10/20 11:22:42, Lasse Reichstein Nielsen wrote:
> I this variable used?

Done.

https://codereview.chromium.org/11230011/diff/1/lib/compiler/implementation/s...
File lib/compiler/implementation/string_validator.dart (right):

https://codereview.chromium.org/11230011/diff/1/lib/compiler/implementation/s...
lib/compiler/implementation/string_validator.dart:61: if (source.hasNext &&
identical(source.next(), quoteChar) && source.hasNext) {
On 2012/10/22 08:12:06, Mads Ager wrote:
> Not your code, but could you reformat to keep within the 80 char limit?

https://codereview.chromium.org/11233035/

Powered by Google App Engine
This is Rietveld 408576698