Issue 11106003: Tweaks workspace animation code per latest from Nicholas. Additionally

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11106003: Tweaks workspace animation code per latest from Nicholas. Additionally (Closed)

Created:
8 years, 2 months ago by sky

Modified:
8 years, 2 months ago

Reviewers:
Ben Goodger (Google)

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Tweaks workspace animation code per latest from Nicholas. Additionally moves the switching animation into its own file and cleans it up. BUG=155179 TEST=none R=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=161591

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+625 lines, -436 lines)			Patch
M	ash/ash.gyp	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	ash/wm/shelf_layout_manager.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	ash/wm/window_animations.h	View	1	3 chunks	+6 lines, -48 lines	0 comments	Download
M	ash/wm/window_animations.cc	View	1	12 chunks	+15 lines, -304 lines	0 comments	Download
A	ash/wm/workspace/desktop_background_fade_controller.h	View	1	1 chunk	+68 lines, -0 lines	0 comments	Download
A	ash/wm/workspace/desktop_background_fade_controller.cc	View		1 chunk	+64 lines, -0 lines	0 comments	Download
M	ash/wm/workspace/workspace2.cc	View		2 chunks	+2 lines, -0 lines	0 comments	Download
A	ash/wm/workspace/workspace_animations.h	View	1	1 chunk	+62 lines, -0 lines	0 comments	Download
A	ash/wm/workspace/workspace_animations.cc	View	1	1 chunk	+161 lines, -0 lines	0 comments	Download
M	ash/wm/workspace/workspace_manager2.h	View		7 chunks	+54 lines, -16 lines	0 comments	Download
M	ash/wm/workspace/workspace_manager2.cc	View	1	22 chunks	+188 lines, -67 lines	0 comments	Download

Total messages: 2 (0 generated)

lgtm