Pull cache out of GrContext

This replaces the texture creation/caching functions on GrContext with a GrTextureProvider interface. The goal is to pass this narrowly focused object in places that currently take a GrContext but don't need and shouldn't use its other methods. It also has an extended private interface for interacting with non-texture resource types.

Committed: https://skia.googlesource.com/skia/+/d309e7aa0efa2d5dd7e7b1af97026fcd3a047e98

[bsalomon, 2015-04-30 19:27:05]

bsalomon@google.com changed reviewers:
+ joshualitt@google.com, robertphillips@google.com

[robertphillips, 2015-04-30 20:43:44]

lgtm + nits & questions

https://codereview.chromium.org/1107973004/diff/60001/include/gpu/GrContext.h
File include/gpu/GrContext.h (right):

https://codereview.chromium.org/1107973004/diff/60001/include/gpu/GrContext.h...
include/gpu/GrContext.h:517:
///////////////////////////////////////////////////////////////////////////
#ifdef LEGACY_TEXTURE_INTF ?

https://codereview.chromium.org/1107973004/diff/60001/include/gpu/GrContext.h...
include/gpu/GrContext.h:533: 
Can we delete contextDestroyed?

https://codereview.chromium.org/1107973004/diff/60001/include/gpu/GrTexturePr...
File include/gpu/GrTextureProvider.h (right):

https://codereview.chromium.org/1107973004/diff/60001/include/gpu/GrTexturePr...
include/gpu/GrTextureProvider.h:12: 
do we need this pre-decl ?

https://codereview.chromium.org/1107973004/diff/60001/src/effects/SkBlurMaskF...
File src/effects/SkBlurMaskFilter.cpp (right):

https://codereview.chromium.org/1107973004/diff/60001/src/effects/SkBlurMaskF...
src/effects/SkBlurMaskFilter.cpp:750: 
Just pass in textureProvider ?

https://codereview.chromium.org/1107973004/diff/60001/src/gpu/GrTextureProvid...
File src/gpu/GrTextureProvider.cpp (right):

https://codereview.chromium.org/1107973004/diff/60001/src/gpu/GrTextureProvid...
src/gpu/GrTextureProvider.cpp:20: GrTexture*
GrTextureProvider::createTexture(const GrSurfaceDesc& desc, bool budgeted,
space here ?

https://codereview.chromium.org/1107973004/diff/60001/src/gpu/GrTextureProvid...
src/gpu/GrTextureProvider.cpp:46: GrTexture*
GrTextureProvider::refScratchTexture(const GrSurfaceDesc& desc, ScratchTexMatch
match,
and here ?

[bsalomon, 2015-04-30 20:58:40]

https://codereview.chromium.org/1107973004/diff/60001/include/gpu/GrContext.h
File include/gpu/GrContext.h (right):

https://codereview.chromium.org/1107973004/diff/60001/include/gpu/GrContext.h...
include/gpu/GrContext.h:517:
///////////////////////////////////////////////////////////////////////////
On 2015/04/30 20:43:44, robertphillips wrote:
> #ifdef LEGACY_TEXTURE_INTF ?

I think I can migrate the chrome callers quickly, and it will reduce the total
number of patches to leave it unconditional.

https://codereview.chromium.org/1107973004/diff/60001/include/gpu/GrContext.h...
include/gpu/GrContext.h:533: 
On 2015/04/30 20:43:44, robertphillips wrote:
> Can we delete contextDestroyed?

Done.

https://codereview.chromium.org/1107973004/diff/60001/include/gpu/GrTexturePr...
File include/gpu/GrTextureProvider.h (right):

https://codereview.chromium.org/1107973004/diff/60001/include/gpu/GrTexturePr...
include/gpu/GrTextureProvider.h:12: 
On 2015/04/30 20:43:44, robertphillips wrote:
> do we need this pre-decl ?

Done.

https://codereview.chromium.org/1107973004/diff/60001/src/effects/SkBlurMaskF...
File src/effects/SkBlurMaskFilter.cpp (right):

https://codereview.chromium.org/1107973004/diff/60001/src/effects/SkBlurMaskF...
src/effects/SkBlurMaskFilter.cpp:750: 
On 2015/04/30 20:43:44, robertphillips wrote:
> Just pass in textureProvider ?

Done.

https://codereview.chromium.org/1107973004/diff/60001/src/gpu/GrTextureProvid...
File src/gpu/GrTextureProvider.cpp (right):

https://codereview.chromium.org/1107973004/diff/60001/src/gpu/GrTextureProvid...
src/gpu/GrTextureProvider.cpp:20: GrTexture*
GrTextureProvider::createTexture(const GrSurfaceDesc& desc, bool budgeted,
On 2015/04/30 20:43:44, robertphillips wrote:
> space here ?

Done.

https://codereview.chromium.org/1107973004/diff/60001/src/gpu/GrTextureProvid...
src/gpu/GrTextureProvider.cpp:46: GrTexture*
GrTextureProvider::refScratchTexture(const GrSurfaceDesc& desc, ScratchTexMatch
match,
On 2015/04/30 20:43:44, robertphillips wrote:
> and here ?

Done.

[bsalomon, 2015-04-30 20:58:45]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-04-30 20:58:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1107973004/#ps80001
(title: "Address comments")

[commit-bot: I haz the power, 2015-04-30 20:59:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1107973004/80001

[commit-bot: I haz the power, 2015-04-30 21:03:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-30 21:03:03]

Try jobs failed on following builders:
  Build-Ubuntu-GCC-Arm7-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Arm...)
  Build-Ubuntu-GCC-Mips-Debug-Android-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-Mip...)
  Build-Ubuntu-GCC-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Ubuntu-GCC-x86...)

[bsalomon, 2015-04-30 21:07:04]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2015-04-30 21:07:05]

The patchset sent to the CQ was uploaded after l-g-t-m from
robertphillips@google.com
Link to the patchset: https://codereview.chromium.org/1107973004/#ps100001
(title: "fixpicturerenderer.cpp")

[commit-bot: I haz the power, 2015-04-30 21:07:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1107973004/100001

[commit-bot: I haz the power, 2015-04-30 21:19:02]

Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/d309e7aa0efa2d5dd7e7b1af97026fcd3a047e98