Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 10963018: Rework arguments of HistoryService::AddPage() (Closed)

Created:
8 years, 3 months ago by akalin
Modified:
8 years, 3 months ago
Reviewers:
sky
CC:
chromium-reviews, tburkard+watch_chromium.org, jam, browser-components-watch_chromium.org, gideonwald, markusheintz_, Shishir, joi+watch-content_chromium.org, cbentzel+watch_chromium.org, samarth, dominich, darin-cc_chromium.org, tim (not reviewing), Raghu Simha, gavinp+prer_chromium.org, haitaol1, Jered, mihaip-chromium-reviews_chromium.org, akalin, tfarina, sreeram, Aaron Boodman, dominich+watch_chromium.org, David Black, James Su, mmenke
Visibility:
Public.

Description

Rework arguments of HistoryService::AddPage() In preparation for adding a timestamp to NavigationEntry, explicitly add a time argument to all variants of HistoryService::AddPage(). Make HistoryAddPageArgs a regular struct (i.e., not ref-counted). Add a default constructor for it. Make arguments to AddPage() match HistoryAddPageArgs constructor. Make HistoryBackend::AddPage avoid mutating its parameter. BUG=128449 TBR=joi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=158063

Patch Set 1 #

Patch Set 2 : Add TODO #

Patch Set 3 : Fix Windows compile #

Unified diffs Side-by-side diffs Delta from patch set Stats (+298 lines, -296 lines) Patch
M chrome/browser/autocomplete/history_contents_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/history_url_provider_unittest.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/bookmarks/bookmark_html_writer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/bookmarks/bookmark_model_unittest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/browsing_data/browsing_data_remover_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history.h View 5 chunks +7 lines, -19 lines 0 comments Download
M chrome/browser/history/history.cc View 2 chunks +14 lines, -19 lines 0 comments Download
M chrome/browser/history/history_backend.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history_backend.cc View 9 chunks +45 lines, -40 lines 0 comments Download
M chrome/browser/history/history_backend_unittest.cc View 5 chunks +18 lines, -24 lines 0 comments Download
M chrome/browser/history/history_extension_api.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/history/history_querying_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/history/history_tab_helper.h View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/history/history_tab_helper.cc View 1 5 chunks +16 lines, -14 lines 0 comments Download
M chrome/browser/history/history_types.h View 2 chunks +18 lines, -23 lines 0 comments Download
M chrome/browser/history/history_types.cc View 1 chunk +25 lines, -24 lines 0 comments Download
M chrome/browser/history/history_unittest.cc View 26 chunks +63 lines, -58 lines 0 comments Download
M chrome/browser/history/top_sites_unittest.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/instant/instant_controller.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/instant/instant_loader.h View 4 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/instant/instant_loader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/prerender/prerender_contents.cc View 3 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/safe_browsing/browser_feature_extractor_unittest.cc View 4 chunks +20 lines, -10 lines 0 comments Download
M chrome/browser/safe_browsing/malware_details_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/search_engines/template_url_service.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/search_engines/template_url_service_unittest.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/typed_urls_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/toolbar/back_forward_menu_model_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/external_tab_container_win.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/bidi_checker_web_ui_test.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/browser/visitedlink/visitedlink_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/tools/profiles/generate_profile.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M content/public/browser/web_contents_delegate.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
akalin
+sky for review
8 years, 3 months ago (2012-09-21 00:58:22 UTC) #1
sky
LGTM
8 years, 3 months ago (2012-09-21 15:54:46 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/akalin@chromium.org/10963018/1034
8 years, 3 months ago (2012-09-21 16:55:42 UTC) #3
commit-bot: I haz the power
Presubmit check for 10963018-1034 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 3 months ago (2012-09-21 16:56:08 UTC) #4
akalin
TBRing joi for content/public/browser trivial changes
8 years, 3 months ago (2012-09-21 17:05:18 UTC) #5
commit-bot: I haz the power
8 years, 3 months ago (2012-09-21 17:05:31 UTC) #6

Powered by Google App Engine
This is Rietveld 408576698