chrome/browser/ui/views/external_tab_container_win.cc - Issue 10963018: Rework arguments of HistoryService::AddPage()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/external_tab_container_win.cc

Issue 10963018: Rework arguments of HistoryService::AddPage() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix Windows compile Created 8 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/views/external_tab_container_win.cc

diff --git a/chrome/browser/ui/views/external_tab_container_win.cc b/chrome/browser/ui/views/external_tab_container_win.cc

index 4753593ee5a02032526cce95e82325a5c3eb0079..9e8d8fac3969650604cb48a23977fd6d81713ef4 100644

--- a/chrome/browser/ui/views/external_tab_container_win.cc

+++ b/chrome/browser/ui/views/external_tab_container_win.cc

@@ -434,9 +434,9 @@ WebContents* ExternalTabContainerWin::OpenURLFromTab(

content::LoadCommittedDetails details;

details.did_replace_entry = false;

- scoped_refptr<history::HistoryAddPageArgs> add_page_args(

+ const history::HistoryAddPageArgs& add_page_args =

tab_contents_->history_tab_helper()->

- CreateHistoryAddPageArgs(params.url, details, nav_params));

+ CreateHistoryAddPageArgs(params.url, details, nav_params);

tab_contents_->history_tab_helper()->

UpdateHistoryForNavigation(add_page_args);