Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3028)

Unified Diff: chrome/browser/history/history_tab_helper.h

Issue 10963018: Rework arguments of HistoryService::AddPage() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix Windows compile Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/history_querying_unittest.cc ('k') | chrome/browser/history/history_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_tab_helper.h
diff --git a/chrome/browser/history/history_tab_helper.h b/chrome/browser/history/history_tab_helper.h
index 58b22aca04507a93da46313ba221e956a887ae9f..51109b48cd0b6c99688be9084faf085211534231 100644
--- a/chrome/browser/history/history_tab_helper.h
+++ b/chrome/browser/history/history_tab_helper.h
@@ -15,7 +15,7 @@ class SkBitmap;
struct ThumbnailScore;
namespace history {
-class HistoryAddPageArgs;
+struct HistoryAddPageArgs;
}
class HistoryTabHelper : public content::WebContentsObserver,
@@ -27,7 +27,7 @@ class HistoryTabHelper : public content::WebContentsObserver,
// Updates history with the specified navigation. This is called by
// OnMsgNavigate to update history state.
void UpdateHistoryForNavigation(
- scoped_refptr<history::HistoryAddPageArgs> add_page_args);
+ const history::HistoryAddPageArgs& add_page_args);
// Sends the page title to the history service. This is called when we receive
// the page title and we know we want to update history.
@@ -35,7 +35,7 @@ class HistoryTabHelper : public content::WebContentsObserver,
// Returns the history::HistoryAddPageArgs to use for adding a page to
// history.
- scoped_refptr<history::HistoryAddPageArgs> CreateHistoryAddPageArgs(
+ history::HistoryAddPageArgs CreateHistoryAddPageArgs(
const GURL& virtual_url,
const content::LoadCommittedDetails& details,
const content::FrameNavigateParams& params);
« no previous file with comments | « chrome/browser/history/history_querying_unittest.cc ('k') | chrome/browser/history/history_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698