Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3472)

Unified Diff: chrome/browser/history/history_types.h

Issue 10963018: Rework arguments of HistoryService::AddPage() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix Windows compile Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/history/history_tab_helper.cc ('k') | chrome/browser/history/history_types.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/history/history_types.h
diff --git a/chrome/browser/history/history_types.h b/chrome/browser/history/history_types.h
index 4e44b4e4ecc2dda01063d1db6a4cc223e8dfbcb4..84bded64ca5dad21b7056c350d55892b44961a86 100644
--- a/chrome/browser/history/history_types.h
+++ b/chrome/browser/history/history_types.h
@@ -360,22 +360,24 @@ struct FilteredURL {
// Navigation -----------------------------------------------------------------
// Marshalling structure for AddPage.
-class HistoryAddPageArgs
- : public base::RefCountedThreadSafe<HistoryAddPageArgs> {
- public:
- HistoryAddPageArgs(const GURL& arg_url,
- base::Time arg_time,
- const void* arg_id_scope,
- int32 arg_page_id,
- const GURL& arg_referrer,
- const history::RedirectList& arg_redirects,
- content::PageTransition arg_transition,
- VisitSource arg_source,
- bool arg_did_replace_entry);
-
- // Returns a new HistoryAddPageArgs that is a copy of this (ref count is
- // of course reset). Ownership of returned object passes to caller.
- HistoryAddPageArgs* Clone() const;
+struct HistoryAddPageArgs {
+ // The default constructor is equivalent to:
+ //
+ // HistoryAddPageArgs(
+ // GURL(), base::Time(), NULL, 0, GURL(),
+ // history::RedirectList(), content::PAGE_TRANSITION_LINK,
+ // SOURCE_BROWSED, false)
+ HistoryAddPageArgs();
+ HistoryAddPageArgs(const GURL& url,
+ base::Time time,
+ const void* id_scope,
+ int32 page_id,
+ const GURL& referrer,
+ const history::RedirectList& redirects,
+ content::PageTransition transition,
+ VisitSource source,
+ bool did_replace_entry);
+ ~HistoryAddPageArgs();
GURL url;
base::Time time;
@@ -388,13 +390,6 @@ class HistoryAddPageArgs
content::PageTransition transition;
VisitSource visit_source;
bool did_replace_entry;
-
- private:
- friend class base::RefCountedThreadSafe<HistoryAddPageArgs>;
-
- ~HistoryAddPageArgs();
-
- DISALLOW_COPY_AND_ASSIGN(HistoryAddPageArgs);
};
// TopSites -------------------------------------------------------------------
« no previous file with comments | « chrome/browser/history/history_tab_helper.cc ('k') | chrome/browser/history/history_types.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698