Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3118)

Unified Diff: chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc

Issue 10963018: Rework arguments of HistoryService::AddPage() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix Windows compile Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc
diff --git a/chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc b/chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc
index db3e0c8986300e14e3e302fde8e027e8386eaba5..9cf6aede5fa9005ce3c5395194068a45bc25e543 100644
--- a/chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc
+++ b/chrome/browser/ui/webui/web_dialog_web_contents_delegate_unittest.cc
@@ -63,12 +63,11 @@ class WebDialogWebContentsDelegateTest : public BrowserWithTestWindowTest {
TEST_F(WebDialogWebContentsDelegateTest, DoNothingMethodsTest) {
// None of the following calls should do anything.
EXPECT_TRUE(test_web_contents_delegate_->IsPopupOrPanel(NULL));
- scoped_refptr<history::HistoryAddPageArgs> should_add_args(
- new history::HistoryAddPageArgs(
+ history::HistoryAddPageArgs should_add_args(
GURL(), base::Time::Now(), 0, 0, GURL(), history::RedirectList(),
- content::PAGE_TRANSITION_TYPED, history::SOURCE_SYNCED, false));
+ content::PAGE_TRANSITION_TYPED, history::SOURCE_SYNCED, false);
EXPECT_FALSE(test_web_contents_delegate_->ShouldAddNavigationToHistory(
- *should_add_args, content::NAVIGATION_TYPE_NEW_PAGE));
+ should_add_args, content::NAVIGATION_TYPE_NEW_PAGE));
test_web_contents_delegate_->NavigationStateChanged(NULL, 0);
test_web_contents_delegate_->ActivateContents(NULL);
test_web_contents_delegate_->LoadingStateChanged(NULL);
« no previous file with comments | « chrome/browser/ui/webui/bidi_checker_web_ui_test.cc ('k') | chrome/browser/visitedlink/visitedlink_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698