Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2135)

Unified Diff: chrome/browser/instant/instant_loader.h

Issue 10963018: Rework arguments of HistoryService::AddPage() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix Windows compile Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/instant/instant_controller.cc ('k') | chrome/browser/instant/instant_loader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/instant/instant_loader.h
diff --git a/chrome/browser/instant/instant_loader.h b/chrome/browser/instant/instant_loader.h
index e767d31a62a0cd026647821c9e869703c796a2a2..c0249eab542e2cf95f2588489d2785966cd92a66 100644
--- a/chrome/browser/instant/instant_loader.h
+++ b/chrome/browser/instant/instant_loader.h
@@ -12,6 +12,7 @@
#include "base/memory/ref_counted.h"
#include "base/memory/scoped_ptr.h"
#include "base/string16.h"
+#include "chrome/browser/history/history_types.h"
#include "chrome/browser/instant/instant_commit_type.h"
#include "content/public/browser/notification_observer.h"
#include "content/public/browser/notification_registrar.h"
@@ -30,10 +31,6 @@ namespace gfx {
class Rect;
}
-namespace history {
-class HistoryAddPageArgs;
-}
-
// InstantLoader is created with an "Instant URL". It loads the URL and tells
// its delegate (usually InstantController) of all interesting events. For
// example, it determines if the page actually supports the Instant API
@@ -95,8 +92,8 @@ class InstantLoader : public content::NotificationObserver {
const std::string& instant_url() const { return instant_url_; }
// Returns info about the last navigation by the Instant page. If the page
- // hasn't navigated since the last Update(), this contains NULL.
- scoped_refptr<history::HistoryAddPageArgs> last_navigation() const {
+ // hasn't navigated since the last Update(), the URL is empty.
+ const history::HistoryAddPageArgs& last_navigation() const {
return last_navigation_;
}
@@ -136,7 +133,7 @@ class InstantLoader : public content::NotificationObserver {
content::NotificationRegistrar registrar_;
// See comments on the getter above.
- scoped_refptr<history::HistoryAddPageArgs> last_navigation_;
+ history::HistoryAddPageArgs last_navigation_;
DISALLOW_COPY_AND_ASSIGN(InstantLoader);
};
« no previous file with comments | « chrome/browser/instant/instant_controller.cc ('k') | chrome/browser/instant/instant_loader.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698