Issue 1092963004: [chrome/browser/extensions] favor DCHECK_CURRENTLY_ON for better logs

Issue 1092963004: [chrome/browser/extensions] favor DCHECK_CURRENTLY_ON for better logs (Closed)

Created:
5 years, 8 months ago by anujsharma

Modified:
5 years, 8 months ago

Reviewers:
not at google - send to devlin

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, mostynb

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

favor DCHECK_CURRENTLY_ON for better logs in chrome/browser/extensions BUG=466848 Committed: https://crrev.com/f2a0b4ecb28f0012325152de861485d536385cc3 Cr-Commit-Position: refs/heads/master@{#326832}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -29 lines)			Patch
M	chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/api/platform_keys/platform_keys_api.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/api/platform_keys/platform_keys_apitest_nss.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/api/streams_private/streams_private_api.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/app_data_migrator.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_garbage_collector.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_gcm_app_handler_unittest.cc	View	2 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_storage_monitor.cc	View	5 chunks	+5 lines, -5 lines	0 comments	Download
M	chrome/browser/extensions/webstore_installer.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/zipfile_installer.cc	View	3 chunks	+3 lines, -3 lines	0 comments	Download

Total messages: 8 (2 generated)

anujsharma

On 2015/04/24 16:03:50, kalman wrote: > lgtm Thanks kalman for lgtm

5 years, 8 months ago (2015-04-24 17:14:59 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092963004/1

5 years, 8 months ago (2015-04-24 17:16:12 UTC) #6

commit-bot: I haz the power

5 years, 8 months ago (2015-04-24 17:54:21 UTC) #8

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/f2a0b4ecb28f0012325152de861485d536385cc3
Cr-Commit-Position: refs/heads/master@{#326832}