Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Unified Diff: chrome/browser/extensions/zipfile_installer.cc

Issue 1092963004: [chrome/browser/extensions] favor DCHECK_CURRENTLY_ON for better logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/webstore_installer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/zipfile_installer.cc
diff --git a/chrome/browser/extensions/zipfile_installer.cc b/chrome/browser/extensions/zipfile_installer.cc
index 6f64b606f53ade82df31f9d14f932919ba535981..aecb2f22743b0f8462e0885e12e8b7b3a0b7c5c4 100644
--- a/chrome/browser/extensions/zipfile_installer.cc
+++ b/chrome/browser/extensions/zipfile_installer.cc
@@ -34,7 +34,7 @@ ZipFileInstaller::ZipFileInstaller(ExtensionService* extension_service)
}
void ZipFileInstaller::LoadFromZipFile(const base::FilePath& path) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
zip_path_ = path;
BrowserThread::PostTask(BrowserThread::FILE,
FROM_HERE,
@@ -101,7 +101,7 @@ void ZipFileInstaller::ReportErrorOnUIThread(const std::string& error) {
}
void ZipFileInstaller::OnUnzipSucceeded(const base::FilePath& unzipped_path) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
BrowserThread::PostTask(
BrowserThread::UI,
FROM_HERE,
@@ -110,7 +110,7 @@ void ZipFileInstaller::OnUnzipSucceeded(const base::FilePath& unzipped_path) {
}
void ZipFileInstaller::OnUnzipFailed(const std::string& error) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
+ DCHECK_CURRENTLY_ON(BrowserThread::IO);
BrowserThread::PostTask(
BrowserThread::UI,
FROM_HERE,
« no previous file with comments | « chrome/browser/extensions/webstore_installer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698