chrome/browser/extensions/extension_gcm_app_handler_unittest.cc - Issue 1092963004: [chrome/browser/extensions] favor DCHECK_CURRENTLY_ON for better logs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_gcm_app_handler_unittest.cc

Issue 1092963004: [chrome/browser/extensions] favor DCHECK_CURRENTLY_ON for better logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/extension_garbage_collector.cc ('k') | chrome/browser/extensions/extension_storage_monitor.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/extension_gcm_app_handler_unittest.cc

diff --git a/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc b/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc

index d5d8f898e15d1f0de3181021925e237e2d0ec284..5355ee0be636bed73e9c5319a4da052aa36e8220 100644

--- a/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc

+++ b/chrome/browser/extensions/extension_gcm_app_handler_unittest.cc

@@ -98,13 +98,13 @@ class Waiter {

private:

void PumpIOLoopCompleted() {

- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

SignalCompleted();

}

void OnIOLoopPump() {

- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));

+ DCHECK_CURRENTLY_ON(content::BrowserThread::IO);

content::BrowserThread::PostTask(

content::BrowserThread::IO,

@@ -113,7 +113,7 @@ class Waiter {

}

void OnIOLoopPumpCompleted() {

- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::IO));

+ DCHECK_CURRENTLY_ON(content::BrowserThread::IO);

content::BrowserThread::PostTask(

content::BrowserThread::UI,

« no previous file with comments | « chrome/browser/extensions/extension_garbage_collector.cc ('k') | chrome/browser/extensions/extension_storage_monitor.cc » ('j') | no next file with comments »