chrome/browser/extensions/app_data_migrator.cc - Issue 1092963004: [chrome/browser/extensions] favor DCHECK_CURRENTLY_ON for better logs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/app_data_migrator.cc

Issue 1092963004: [chrome/browser/extensions] favor DCHECK_CURRENTLY_ON for better logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/web_request/chrome_extension_web_request_event_router_delegate.cc ('k') | chrome/browser/extensions/extension_garbage_collector.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/app_data_migrator.cc

diff --git a/chrome/browser/extensions/app_data_migrator.cc b/chrome/browser/extensions/app_data_migrator.cc

index 4f3203540d57123fc7180042a6f12da7ada9b093..c2734c12b40ed65a048d1aaaf1bbc6ef3e07af3d 100644

--- a/chrome/browser/extensions/app_data_migrator.cc

+++ b/chrome/browser/extensions/app_data_migrator.cc

@@ -80,7 +80,7 @@ void MigrateFileSystem(WeakPtr<extensions::AppDataMigrator> migrator,

StoragePartition* current_partition,

const extensions::Extension* extension,

const base::Closure& reply) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

// Since this method is static and it's being run as a closure task, check to

// make sure the calling object is still around.

@@ -107,7 +107,7 @@ void MigrateLegacyPartition(WeakPtr<extensions::AppDataMigrator> migrator,

StoragePartition* current_partition,

const extensions::Extension* extension,

const base::Closure& reply) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

IndexedDBContext* indexed_db_context =

current_partition->GetIndexedDBContext();

@@ -149,7 +149,7 @@ bool AppDataMigrator::NeedsMigration(const Extension* old,

void AppDataMigrator::DoMigrationAndReply(const Extension* old,

const Extension* extension,

const base::Closure& reply) {

- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

DCHECK(NeedsMigration(old, extension));

// This should retrieve the general storage partition.