chrome/browser/extensions/api/platform_keys/platform_keys_api.cc - Issue 1092963004: [chrome/browser/extensions] favor DCHECK_CURRENTLY_ON for better logs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/platform_keys/platform_keys_api.cc

Issue 1092963004: [chrome/browser/extensions] favor DCHECK_CURRENTLY_ON for better logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api.cc ('k') | chrome/browser/extensions/api/platform_keys/platform_keys_apitest_nss.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/platform_keys/platform_keys_api.cc

diff --git a/chrome/browser/extensions/api/platform_keys/platform_keys_api.cc b/chrome/browser/extensions/api/platform_keys/platform_keys_api.cc

index 117618736aed3136333e9d78c8fb52b858e206da..487b92eb805ccee85e38e00a83d3c21458dae758 100644

--- a/chrome/browser/extensions/api/platform_keys/platform_keys_api.cc

+++ b/chrome/browser/extensions/api/platform_keys/platform_keys_api.cc

@@ -177,7 +177,7 @@ PlatformKeysInternalSelectClientCertificatesFunction::Run() {

void PlatformKeysInternalSelectClientCertificatesFunction::

OnSelectedCertificates(scoped_ptr<net::CertificateList> matches,

const std::string& error_message) {

- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

if (!error_message.empty()) {

Respond(Error(error_message));

return;

@@ -266,7 +266,7 @@ ExtensionFunction::ResponseAction PlatformKeysInternalSignFunction::Run() {

void PlatformKeysInternalSignFunction::OnSigned(

const std::string& signature,

const std::string& error_message) {

- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

if (error_message.empty())

Respond(ArgumentList(api_pki::Sign::Results::Create(

std::vector<char>(signature.begin(), signature.end()))));