Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3940)

Unified Diff: chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api.cc

Issue 1092963004: [chrome/browser/extensions] favor DCHECK_CURRENTLY_ON for better logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/extensions/api/platform_keys/platform_keys_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api.cc
diff --git a/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api.cc b/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api.cc
index f4b8f745c6974e7bdd88a82e2eded347313135ea..9c5e57d7226edd73a4d1db09a0b744afe0951f76 100644
--- a/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api.cc
+++ b/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api.cc
@@ -64,7 +64,7 @@ EnterprisePlatformKeysInternalGenerateKeyFunction::Run() {
void EnterprisePlatformKeysInternalGenerateKeyFunction::OnGeneratedKey(
const std::string& public_key_der,
const std::string& error_message) {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
if (error_message.empty()) {
Respond(ArgumentList(api_epki::GenerateKey::Results::Create(
std::vector<char>(public_key_der.begin(), public_key_der.end()))));
@@ -98,7 +98,7 @@ EnterprisePlatformKeysGetCertificatesFunction::Run() {
void EnterprisePlatformKeysGetCertificatesFunction::OnGotCertificates(
scoped_ptr<net::CertificateList> certs,
const std::string& error_message) {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
if (!error_message.empty()) {
Respond(Error(error_message));
return;
@@ -151,7 +151,7 @@ EnterprisePlatformKeysImportCertificateFunction::Run() {
void EnterprisePlatformKeysImportCertificateFunction::OnImportedCertificate(
const std::string& error_message) {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
if (error_message.empty())
Respond(NoArguments());
else
@@ -190,7 +190,7 @@ EnterprisePlatformKeysRemoveCertificateFunction::Run() {
void EnterprisePlatformKeysRemoveCertificateFunction::OnRemovedCertificate(
const std::string& error_message) {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
if (error_message.empty())
Respond(NoArguments());
else
@@ -215,7 +215,7 @@ EnterprisePlatformKeysInternalGetTokensFunction::Run() {
void EnterprisePlatformKeysInternalGetTokensFunction::OnGotTokens(
scoped_ptr<std::vector<std::string> > platform_keys_token_ids,
const std::string& error_message) {
- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);
if (!error_message.empty()) {
Respond(Error(error_message));
return;
« no previous file with comments | « no previous file | chrome/browser/extensions/api/platform_keys/platform_keys_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698