Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1092123004: DevTools: remove dependency of most agents on InspectorPageAgent (Closed)

Created:
5 years, 8 months ago by caseq
Modified:
5 years, 7 months ago
Reviewers:
dgozman, pfeldman, yurys
CC:
blink-reviews, Eric Willigers, caseq+blink_chromium.org, shans, loislo+blink_chromium.org, dstockwell, blink-reviews-animation_chromium.org, darktears, yurys+blink_chromium.org, lushnikov+blink_chromium.org, Mike Lawther (Google), pfeldman+blink_chromium.org, Timothy Loh, Steve Block, apavlov+blink_chromium.org, devtools-reviews_chromium.org, rjwright, sergeyv+blink_chromium.org, aandrey+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

DevTools: remove dependency of most agents on InspectorPageAgent - let agents keep inspected frame directly rather than fetch it from InspectorPageAgent::inspectedFrame(); - get frames from InspectorIdentifiers<LocalFrame>, but check it belongs to inspected page; BUG=480341 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194592

Patch Set 1 #

Patch Set 2 : further cuts on InspectorPageAgent inter-agents API #

Total comments: 7

Patch Set 3 : addressed yurys comments, added InspectorResolver #

Total comments: 4

Patch Set 4 : moar cleanup #

Patch Set 5 : rebased #

Patch Set 6 : fixed debug build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+244 lines, -219 lines) Patch
M Source/core/core.gypi View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorAnimationAgent.h View 1 2 3 chunks +5 lines, -7 lines 0 comments Download
M Source/core/inspector/InspectorAnimationAgent.cpp View 7 chunks +7 lines, -8 lines 0 comments Download
M Source/core/inspector/InspectorApplicationCacheAgent.h View 1 2 3 3 chunks +4 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorApplicationCacheAgent.cpp View 1 2 6 chunks +16 lines, -11 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.h View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 1 2 5 chunks +7 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.h View 4 chunks +4 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 1 2 3 4 5 10 chunks +26 lines, -22 lines 0 comments Download
M Source/core/inspector/InspectorInputAgent.h View 1 2 2 chunks +5 lines, -7 lines 0 comments Download
M Source/core/inspector/InspectorInputAgent.cpp View 3 chunks +5 lines, -6 lines 0 comments Download
M Source/core/inspector/InspectorLayerTreeAgent.h View 4 chunks +4 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorLayerTreeAgent.cpp View 5 chunks +8 lines, -11 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.h View 1 2 3 2 chunks +1 line, -6 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 1 2 3 10 chunks +11 lines, -46 lines 0 comments Download
A Source/core/inspector/InspectorResolver.h View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
A Source/core/inspector/InspectorResolver.cpp View 1 2 1 chunk +39 lines, -0 lines 0 comments Download
M Source/core/inspector/InspectorResourceAgent.h View 4 chunks +4 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorResourceAgent.cpp View 1 2 7 chunks +8 lines, -7 lines 0 comments Download
M Source/core/inspector/InspectorTracingAgent.h View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorTracingAgent.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M Source/core/inspector/PageConsoleAgent.h View 2 chunks +4 lines, -5 lines 0 comments Download
M Source/core/inspector/PageConsoleAgent.cpp View 4 chunks +5 lines, -6 lines 0 comments Download
M Source/core/inspector/PageDebuggerAgent.h View 1 2 3 chunks +4 lines, -5 lines 0 comments Download
M Source/core/inspector/PageDebuggerAgent.cpp View 1 6 chunks +10 lines, -11 lines 0 comments Download
M Source/core/inspector/PageRuntimeAgent.h View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/inspector/PageRuntimeAgent.cpp View 5 chunks +5 lines, -6 lines 0 comments Download
M Source/web/WebDevToolsAgentImpl.cpp View 1 2 3 4 5 4 chunks +16 lines, -14 lines 0 comments Download

Messages

Total messages: 19 (9 generated)
caseq
This is on top of https://codereview.chromium.org/1085033003/
5 years, 8 months ago (2015-04-23 17:57:42 UTC) #2
yurys
lgtm https://codereview.chromium.org/1092123004/diff/20001/Source/core/inspector/InspectorAnimationAgent.h File Source/core/inspector/InspectorAnimationAgent.h (right): https://codereview.chromium.org/1092123004/diff/20001/Source/core/inspector/InspectorAnimationAgent.h#newcode20 Source/core/inspector/InspectorAnimationAgent.h:20: class InspectorDOMAgent; class LocalFrame; https://codereview.chromium.org/1092123004/diff/20001/Source/core/inspector/InspectorDOMAgent.cpp File Source/core/inspector/InspectorDOMAgent.cpp (left): ...
5 years, 8 months ago (2015-04-24 08:54:41 UTC) #3
caseq
Dmitry, ptal -- now looking up nodes/frames via InspectorResolver as discussed offline.
5 years, 8 months ago (2015-04-24 12:54:59 UTC) #4
dgozman
lgtm https://codereview.chromium.org/1092123004/diff/40001/Source/core/inspector/InspectorPageAgent.cpp File Source/core/inspector/InspectorPageAgent.cpp (left): https://codereview.chromium.org/1092123004/diff/40001/Source/core/inspector/InspectorPageAgent.cpp#oldcode202 Source/core/inspector/InspectorPageAgent.cpp:202: DocumentLoader* loader = InspectorPageAgent::assertDocumentLoader(errorString, frame); Won't this crash ...
5 years, 8 months ago (2015-04-24 13:16:14 UTC) #5
caseq
https://codereview.chromium.org/1092123004/diff/40001/Source/core/inspector/InspectorPageAgent.cpp File Source/core/inspector/InspectorPageAgent.cpp (left): https://codereview.chromium.org/1092123004/diff/40001/Source/core/inspector/InspectorPageAgent.cpp#oldcode202 Source/core/inspector/InspectorPageAgent.cpp:202: DocumentLoader* loader = InspectorPageAgent::assertDocumentLoader(errorString, frame); On 2015/04/24 13:16:14, dgozman ...
5 years, 8 months ago (2015-04-24 13:50:55 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092123004/80001
5 years, 8 months ago (2015-04-25 15:33:10 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/43050)
5 years, 8 months ago (2015-04-25 15:55:12 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1092123004/100001
5 years, 7 months ago (2015-04-28 10:28:23 UTC) #17
commit-bot: I haz the power
Committed patchset #6 (id:100001) as https://src.chromium.org/viewvc/blink?view=rev&revision=194592
5 years, 7 months ago (2015-04-28 11:40:34 UTC) #18
caseq
5 years, 7 months ago (2015-05-01 10:43:03 UTC) #19
Message was sent while issue was closed. 
A revert of this CL (patchset #6 id:100001) has been created in
https://codereview.chromium.org/1118963002/ by caseq@chromium.org.

The reason for reverting is: Reverting as a possible cause of issue 482468
BUG=482468.

Powered by Google App Engine
This is Rietveld 408576698