DevTools: remove dependency of most agents on InspectorPageAgent

Source/core/inspector/InspectorPageAgent.h

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 105 matching lines @@
     void didLayout();
     void didScroll();
     void didResizeMainFrame();
     void didRecalculateStyle(int);
 
     // Inspector Controller API
     void disable(ErrorString*) override;
     void restore() override;
     void discardAgent() override;
 
     // Cross-agents API

[dgozman, 2015/04/24 13:16:14]

I thought all cross-agents methods are gone now.

[caseq, 2015/04/24 13:50:55]

resourceContentLoader() is still used by CSS agent (it should be possible to get
rid of it, too, but let's do it in a separate patch; screencastEnabled() is also
used by WebDevToolsAgentImpl).

findFrameWithSecurityOrigin() proved to be unused, so nuking it now.

-    static DocumentLoader* assertDocumentLoader(ErrorString*, LocalFrame*);
-    LocalFrame* frameForId(const String& frameId);
-    LocalFrame* assertFrame(ErrorString*, const String& frameId);
-    FrameHost* frameHost();
-    LocalFrame* inspectedFrame() const { return m_inspectedFrame.get(); }
     LocalFrame* findFrameWithSecurityOrigin(const String& originRawString);
     bool screencastEnabled();
     InspectorResourceContentLoader* resourceContentLoader() { return m_inspectorResourceContentLoader.get(); }
 
     DECLARE_VIRTUAL_TRACE();
 
 private:
     class GetResourceContentLoadListener;
 
     InspectorPageAgent(LocalFrame* inspectedFrame, InspectorOverlay*);
 
     void finishReload();
     void getResourceContentAfterResourcesContentLoaded(const String& frameId, const String& url, PassRefPtrWillBeRawPtr<GetResourceContentCallback>);
+    LocalFrame* assertFrame(ErrorString*, const String& frameId);
 
     static bool dataContent(const char* data, unsigned size, const String& textEncodingName, bool withBase64Encode, String* result);
 
     PassRefPtr<TypeBuilder::Page::Frame> buildObjectForFrame(LocalFrame*);
     PassRefPtr<TypeBuilder::Page::FrameResourceTree> buildObjectForFrameTree(LocalFrame*);
     RawPtrWillBeMember<LocalFrame> m_inspectedFrame;
     RawPtrWillBeMember<InspectorDebuggerAgent> m_debuggerAgent;
     RawPtrWillBeMember<InspectorCSSAgent> m_cssAgent;
     RawPtrWillBeMember<InspectorOverlay> m_overlay;
     long m_lastScriptIdentifier;
     String m_pendingScriptToEvaluateOnLoadOnce;
     String m_scriptToEvaluateOnLoadOnce;
     bool m_enabled;
     bool m_reloading;
 
     OwnPtrWillBeMember<InspectorResourceContentLoader> m_inspectorResourceContentLoader;
 };
 
 
 } // namespace blink
 
 
 #endif // !defined(InspectorPagerAgent_h)