Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Side by Side Diff: Source/core/inspector/PageDebuggerAgent.h

Issue 1092123004: DevTools: remove dependency of most agents on InspectorPageAgent (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: further cuts on InspectorPageAgent inter-agents API Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 20 matching lines...) Expand all
31 #ifndef PageDebuggerAgent_h 31 #ifndef PageDebuggerAgent_h
32 #define PageDebuggerAgent_h 32 #define PageDebuggerAgent_h
33 33
34 #include "bindings/core/v8/PageScriptDebugServer.h" 34 #include "bindings/core/v8/PageScriptDebugServer.h"
35 #include "core/inspector/InspectorDebuggerAgent.h" 35 #include "core/inspector/InspectorDebuggerAgent.h"
36 #include "core/inspector/InspectorOverlay.h" 36 #include "core/inspector/InspectorOverlay.h"
37 37
38 namespace blink { 38 namespace blink {
39 39
40 class DocumentLoader; 40 class DocumentLoader;
41 class InspectorPageAgent;
42 class PageScriptDebugServer; 41 class PageScriptDebugServer;
yurys 2015/04/24 08:54:41 class LocalFrame;
43 42
44 class PageDebuggerAgent final 43 class PageDebuggerAgent final
45 : public InspectorDebuggerAgent 44 : public InspectorDebuggerAgent
46 , public InspectorOverlay::Listener { 45 , public InspectorOverlay::Listener {
47 WTF_MAKE_NONCOPYABLE(PageDebuggerAgent); 46 WTF_MAKE_NONCOPYABLE(PageDebuggerAgent);
48 WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED(PageDebuggerAgent); 47 WTF_MAKE_FAST_ALLOCATED_WILL_BE_REMOVED(PageDebuggerAgent);
49 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(PageDebuggerAgent); 48 WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(PageDebuggerAgent);
50 public: 49 public:
51 static PassOwnPtrWillBeRawPtr<PageDebuggerAgent> create(PageScriptDebugServe r*, InspectorPageAgent*, InjectedScriptManager*, InspectorOverlay*, int debugger Id); 50 static PassOwnPtrWillBeRawPtr<PageDebuggerAgent> create(LocalFrame* inspecte dFrame, PageScriptDebugServer*, InjectedScriptManager*, InspectorOverlay*, int d ebuggerId);
52 ~PageDebuggerAgent() override; 51 ~PageDebuggerAgent() override;
53 DECLARE_VIRTUAL_TRACE(); 52 DECLARE_VIRTUAL_TRACE();
54 53
55 void didStartProvisionalLoad(LocalFrame*); 54 void didStartProvisionalLoad(LocalFrame*);
56 void didClearDocumentOfWindowObject(LocalFrame*); 55 void didClearDocumentOfWindowObject(LocalFrame*);
57 void didCommitLoadForLocalFrame(LocalFrame*) override; 56 void didCommitLoadForLocalFrame(LocalFrame*) override;
58 57
59 protected: 58 protected:
60 void enable() override; 59 void enable() override;
61 void disable() override; 60 void disable() override;
62 61
63 private: 62 private:
64 void startListeningScriptDebugServer() override; 63 void startListeningScriptDebugServer() override;
65 void stopListeningScriptDebugServer() override; 64 void stopListeningScriptDebugServer() override;
66 PageScriptDebugServer& scriptDebugServer() override; 65 PageScriptDebugServer& scriptDebugServer() override;
67 void muteConsole() override; 66 void muteConsole() override;
68 void unmuteConsole() override; 67 void unmuteConsole() override;
69 68
70 // InspectorOverlay::Listener implementation. 69 // InspectorOverlay::Listener implementation.
71 void overlayResumed() override; 70 void overlayResumed() override;
72 void overlaySteppedOver() override; 71 void overlaySteppedOver() override;
73 72
74 InjectedScript injectedScriptForEval(ErrorString*, const int* executionConte xtId) override; 73 InjectedScript injectedScriptForEval(ErrorString*, const int* executionConte xtId) override;
75 74
76 PageDebuggerAgent(PageScriptDebugServer*, InspectorPageAgent*, InjectedScrip tManager*, InspectorOverlay*, int debuggerId); 75 PageDebuggerAgent(LocalFrame* inspectedFrame, PageScriptDebugServer*, Inject edScriptManager*, InspectorOverlay*, int debuggerId);
76 RawPtrWillBeMember<LocalFrame> m_inspectedFrame;
77 RawPtrWillBeMember<PageScriptDebugServer> m_pageScriptDebugServer; 77 RawPtrWillBeMember<PageScriptDebugServer> m_pageScriptDebugServer;
78 RawPtrWillBeMember<InspectorPageAgent> m_pageAgent;
79 RawPtrWillBeMember<InspectorOverlay> m_overlay; 78 RawPtrWillBeMember<InspectorOverlay> m_overlay;
80 int m_debuggerId; 79 int m_debuggerId;
81 }; 80 };
82 81
83 } // namespace blink 82 } // namespace blink
84 83
85 84
86 #endif // !defined(PageDebuggerAgent_h) 85 #endif // !defined(PageDebuggerAgent_h)
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698