Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1109)

Issue 1083683003: Speculative revert by sheriff (Closed)

Created:
5 years, 8 months ago by bartfab (slow)
Modified:
5 years, 8 months ago
Reviewers:
akuegel
CC:
chromium-reviews, posciak+watch_chromium.org, sadrul, qsr+mojo_chromium.org, zea+watch_chromium.org, mlamouri+watch-content_chromium.org, michaelpg+watch-md-settings_chromium.org, yzshen+watch_chromium.org, sievers+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, arv+watch_chromium.org, piman+watch_chromium.org, khorimoto+watch-md-settings_chromium.org, stevenjb+watch_chromium.org, danakj+watch_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, ben+mojo_chromium.org, lcwu+watch_chromium.org, dzhioev+watch_chromium.org, jam, abarth-chromium, jbauman+watch_chromium.org, pvalenzuela+watch_chromium.org, darin-cc_chromium.org, yfriedman+watch_chromium.org, darin (slow to review), chromium-apps-reviews_chromium.org, auto-bisect-reviews_chromium.org, jbudorick+watch_chromium.org, dbeam+watch-closure_chromium.org, wjia+watch_chromium.org, asvitkine+watch_chromium.org, vitalyp+closure_chromium.org, mlamouri+watch-notifications_chromium.org, viettrungluu+watch_chromium.org, jhawkins+watch-md-settings_chromium.org, feature-media-reviews_chromium.org, jlklein+watch-md-settings_chromium.org, oshima+watch_chromium.org, kalyank, gunsch+watch_chromium.org, klundberg+watch_chromium.org, maniscalco+watch_chromium.org, Ian Vollick, peter+watch_chromium.org, maxbogue+watch_chromium.org, avayvod+watch_chromium.org, mcasas+watch_chromium.org, orenb+watch-md-settings_chromium.org, Aaron Boodman, plaree+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, cc-bugs_chromium.org, stevenjb+watch-md-settings_chromium.org, davemoore+watch_chromium.org, Lei Zhang
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Speculative revert by sheriff I am reverting all CLs that could have caused this failure: http://build.chromium.org/p/chromium.linux/builders/ Android%20Tests%20%28dbg%29/builds/27276 I will start re-landing vindicated CLs shortly. Revert "Convert a11y_page.css to a11y_page_style.html. See http://goo.gl/vIGSCO for more information." This reverts commit eb48d65705e44b80d1d7a3b4f21c567802c102bb. Revert "Supply build properties to run-bisect-perf regression for android bisects." This reverts commit 9d70bb94984b02c17678ccf482d1a7b7c760a43f. Revert "[cros New-GAIA] Webview login and new GAIA endpoint enabled by default" This reverts commit 29061783f8b59f1e78286a87a3bb7d18129f639a. Revert "Prime the landing pad for the new video rendering pipeline." This reverts commit 45a3c93f745eabf6c1b1cbdac87ed4350a919e76. Revert "Implement separate error dialog for cws widget container" This reverts commit 7ed1f876f6f4d79ac074b25f2066d514603aa18d. Revert "Create device_bluetooth watchlist; add scheib." This reverts commit 40514c99cd45d1c8e9caef3245d42533d9810179. Revert "Convert checkbox.css to checkbox_style.html. See http://goo.gl/vIGSCO for more information." This reverts commit a687f31a786645508622482e9033f497364a43cd. Revert "Created new URLRequestContext for secure proxy check." This reverts commit 652eabf1141c00594aa6e9ed81beb980aec89198. Revert "Revert of Fix scroll regression when specifying an extension id. (patchset #4 id:60001 of https://codereview.chromium.org/1064573003/)" This reverts commit 488846cd562f444831982d82ef0bc9ca0dd79028. Revert "Sync: Add Android test for downloading a bookmark" This reverts commit 9c052713563111ac3d6cc64d4b5cfdfa27c202f4. Revert "ScreenOrientationController to start observing even without an internal display." This reverts commit 31fed68a524d49f99cebf02dca6ad49019e9900c. Revert "Fix MB configurations for Mac and Win GN bots." This reverts commit 31a66f3e705d20a39033a7b7d7f09a60517e6b9d. Revert "Add tool/perf/measurements path to check for CQ jobs." This reverts commit 99e1ac1d217174dad7a862f6a0fc44950d503737. Revert "Implement Notification.data for persistent notifications." This reverts commit 539f51d6af62097059c34b1c19dfbc4352413ad7. Revert "Fix playback rate calculations for WallClockTimeSource." This reverts commit 3ec02d642465872d9ab7d7db600d0480a57b3cab. Revert "Roll src/third_party/pdfium eddab44:b330016" This reverts commit 81d51e253cfacd5648cca9f12b605e63971a9ab1. Revert "cc: Make DisplayItemList::Append replay into an SkPicture" This reverts commit ec7c07e57bc5f91e3ba0bdeba8b6f534978615b0. Revert "Clean up URLFetcher unit tests, part 5." This reverts commit 8eeb3bf4a02be612cacb3cdbb5c223d909939527. BUG=None TBR=akuegel Committed: https://chromium.googlesource.com/chromium/src/+/919dce4400651813d5ff6e8a85b944a5987adcb7

Patch Set 1 #

Patch Set 2 : Removed an unrelated commit that had accidentally slipped in. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1990 lines, -1828 lines) Patch
M BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M WATCHLISTS View 2 chunks +0 lines, -4 lines 0 comments Download
M ash/content/display/screen_orientation_controller_chromeos.cc View 3 chunks +10 lines, -12 lines 0 comments Download
M ash/content/display/screen_orientation_controller_chromeos_unittest.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M build/android/buildbot/bb_host_steps.py View 2 chunks +1 line, -4 lines 0 comments Download
M build/gn_migration.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M cc/blink/web_compositor_support_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/blink/web_compositor_support_impl.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/blink/web_content_layer_impl.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/blink/web_content_layer_impl.cc View 1 chunk +5 lines, -4 lines 0 comments Download
M cc/blink/web_display_item_list_impl.h View 2 chunks +4 lines, -2 lines 0 comments Download
M cc/blink/web_display_item_list_impl.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M cc/debug/rasterize_and_record_benchmark.cc View 1 chunk +2 lines, -5 lines 0 comments Download
M cc/layers/content_layer_client.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/layers/picture_image_layer.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/layers/picture_image_layer.cc View 1 chunk +5 lines, -3 lines 0 comments Download
M cc/layers/picture_image_layer_unittest.cc View 1 chunk +2 lines, -37 lines 0 comments Download
M cc/layers/picture_layer_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layers/video_frame_provider.h View 3 chunks +21 lines, -49 lines 0 comments Download
M cc/layers/video_frame_provider_client_impl.h View 2 chunks +1 line, -3 lines 0 comments Download
M cc/layers/video_frame_provider_client_impl.cc View 2 chunks +3 lines, -12 lines 0 comments Download
M cc/layers/video_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/resources/display_item.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/resources/display_item.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M cc/resources/display_item_list.h View 3 chunks +5 lines, -9 lines 0 comments Download
M cc/resources/display_item_list.cc View 4 chunks +20 lines, -43 lines 0 comments Download
M cc/resources/display_item_list_unittest.cc View 10 chunks +12 lines, -28 lines 0 comments Download
M cc/resources/display_list_recording_source.cc View 1 chunk +6 lines, -7 lines 0 comments Download
M cc/resources/drawing_display_item.h View 1 chunk +1 line, -0 lines 0 comments Download
M cc/resources/drawing_display_item.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M cc/test/fake_content_layer_client.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/test/fake_content_layer_client.cc View 3 chunks +11 lines, -10 lines 0 comments Download
M cc/test/fake_display_list_recording_source.h View 1 chunk +3 lines, -5 lines 0 comments Download
M cc/test/fake_video_frame_provider.h View 1 chunk +1 line, -3 lines 0 comments Download
M cc/test/fake_video_frame_provider.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M cc/test/solid_color_content_layer_client.h View 1 chunk +1 line, -2 lines 0 comments Download
M cc/test/solid_color_content_layer_client.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_host_pixeltest_masks.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/FakeServerHelper.java View 4 chunks +12 lines, -40 lines 0 comments Download
M chrome/android/sync_shell/javatests/src/chromium/chrome/browser/sync/SyncTest.java View 1 chunk +0 lines, -17 lines 0 comments Download
M chrome/browser/chromeos/login/helper.cc View 1 chunk +2 lines, -14 lines 0 comments Download
M chrome/browser/chromeos/login/hid_detection_browsertest.cc View 2 chunks +4 lines, -12 lines 0 comments Download
M chrome/browser/chromeos/login/login_browsertest.cc View 4 chunks +2 lines, -33 lines 0 comments Download
M chrome/browser/chromeos/login/login_manager_test.h View 2 chunks +0 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/login_manager_test.cc View 3 chunks +1 line, -31 lines 0 comments Download
M chrome/browser/chromeos/login/oobe_browsertest.cc View 6 chunks +44 lines, -22 lines 0 comments Download
M chrome/browser/chromeos/login/proxy_auth_dialog_browsertest.cc View 3 chunks +4 lines, -16 lines 0 comments Download
M chrome/browser/chromeos/login/saml/saml_browsertest.cc View 4 chunks +5 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 3 chunks +13 lines, -39 lines 0 comments Download
M chrome/browser/chromeos/login/signin/oauth2_browsertest.cc View 12 chunks +23 lines, -21 lines 0 comments Download
M chrome/browser/chromeos/login/startup_utils.cc View 3 chunks +10 lines, -27 lines 0 comments Download
M chrome/browser/chromeos/login/test/oobe_base_test.h View 3 chunks +0 lines, -25 lines 0 comments Download
M chrome/browser/chromeos/login/test/oobe_base_test.cc View 9 chunks +20 lines, -54 lines 0 comments Download
M chrome/browser/chromeos/login/webview_login_browsertest.cc View 3 chunks +37 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/wizard_controller_browsertest.cc View 6 chunks +2 lines, -39 lines 0 comments Download
M chrome/browser/chromeos/policy/blocking_login_browsertest.cc View 4 chunks +25 lines, -12 lines 0 comments Download
M chrome/browser/resources/extensions/extension_list.js View 2 chunks +21 lines, -8 lines 0 comments Download
M chrome/browser/resources/extensions/extensions.js View 1 chunk +0 lines, -1 line 0 comments Download
A + chrome/browser/resources/settings/a11y_page/a11y_page.css View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/a11y_page/a11y_page.html View 1 chunk +1 line, -2 lines 0 comments Download
D chrome/browser/resources/settings/a11y_page/a11y_page_style.html View 1 chunk +0 lines, -24 lines 0 comments Download
A + chrome/browser/resources/settings/checkbox/checkbox.css View 2 chunks +3 lines, -4 lines 0 comments Download
M chrome/browser/resources/settings/checkbox/checkbox.html View 1 chunk +1 line, -2 lines 0 comments Download
D chrome/browser/resources/settings/checkbox/checkbox_style.html View 1 chunk +0 lines, -20 lines 0 comments Download
M chrome/browser/resources/settings/settings_resources.grd View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/common/pref_names.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/interactive_ui_tests.isolate View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/test/data/notifications/platform_notification_service.html View 1 chunk +1 line, -4 lines 0 comments Download
M chromecast/media/base/switching_media_renderer.h View 1 chunk +1 line, -0 lines 0 comments Download
M chromecast/media/base/switching_media_renderer.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chromecast/media/cma/filters/cma_renderer.h View 4 chunks +3 lines, -4 lines 0 comments Download
M chromecast/media/cma/filters/cma_renderer.cc View 6 chunks +5 lines, -8 lines 0 comments Download
M chromecast/renderer/media/chromecast_media_renderer_factory.h View 1 chunk +1 line, -2 lines 0 comments Download
M chromecast/renderer/media/chromecast_media_renderer_factory.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_config.h View 9 chunks +18 lines, -17 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc View 8 chunks +36 lines, -110 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.h View 1 chunk +0 lines, -3 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_config_test_utils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_config_unittest.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_io_data.cc View 2 chunks +6 lines, -5 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_service.h View 6 chunks +28 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_service.cc View 2 chunks +46 lines, -0 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_settings_unittest.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M components/data_reduction_proxy/core/browser/data_reduction_proxy_test_utils.h View 1 chunk +3 lines, -0 lines 0 comments Download
M content/browser/notifications/notification_database_data.proto View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/notifications/notification_database_data_conversions.cc View 2 chunks +0 lines, -10 lines 0 comments Download
M content/browser/notifications/notification_database_data_unittest.cc View 3 chunks +0 lines, -9 lines 0 comments Download
M content/child/notifications/notification_data_conversions.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M content/child/notifications/notification_data_conversions_unittest.cc View 7 chunks +4 lines, -20 lines 0 comments Download
M content/child/notifications/notification_manager.cc View 2 chunks +0 lines, -21 lines 0 comments Download
M content/common/platform_notification_messages.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/platform_notification_data.h View 4 chunks +2 lines, -11 lines 0 comments Download
M content/public/common/platform_notification_data.cc View 1 chunk +3 lines, -1 line 0 comments Download
M content/renderer/media/android/webmediaplayer_android.h View 1 chunk +1 line, -3 lines 0 comments Download
M content/renderer/media/android/webmediaplayer_android.cc View 2 chunks +2 lines, -7 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.h View 1 chunk +1 line, -3 lines 0 comments Download
M content/renderer/media/webmediaplayer_ms.cc View 2 chunks +2 lines, -9 lines 0 comments Download
M media/BUILD.gn View 1 chunk +31 lines, -0 lines 0 comments Download
M media/base/mock_filters.h View 2 chunks +13 lines, -11 lines 0 comments Download
M media/base/pipeline.h View 3 chunks +4 lines, -0 lines 0 comments Download
M media/base/pipeline.cc View 4 chunks +4 lines, -0 lines 0 comments Download
M media/base/pipeline_unittest.cc View 5 chunks +8 lines, -5 lines 0 comments Download
M media/base/renderer.h View 2 chunks +4 lines, -0 lines 0 comments Download
M media/base/renderer_factory.h View 2 chunks +2 lines, -5 lines 0 comments Download
M media/base/video_renderer.h View 2 chunks +4 lines, -0 lines 0 comments Download
D media/base/video_renderer_sink.h View 1 chunk +0 lines, -64 lines 0 comments Download
M media/base/wall_clock_time_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/base/wall_clock_time_source_unittest.cc View 4 chunks +2 lines, -26 lines 0 comments Download
M media/blink/video_frame_compositor.h View 2 chunks +13 lines, -65 lines 0 comments Download
M media/blink/video_frame_compositor.cc View 2 chunks +5 lines, -84 lines 0 comments Download
M media/blink/video_frame_compositor_unittest.cc View 7 chunks +11 lines, -16 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 4 chunks +18 lines, -9 lines 0 comments Download
M media/media.gyp View 1 chunk +38 lines, -0 lines 0 comments Download
M media/mojo/services/mojo_renderer_factory.h View 1 chunk +1 line, -2 lines 0 comments Download
M media/mojo/services/mojo_renderer_factory.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/mojo/services/mojo_renderer_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/mojo/services/mojo_renderer_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download
M media/mojo/services/mojo_renderer_service.h View 2 chunks +0 lines, -2 lines 0 comments Download
M media/mojo/services/mojo_renderer_service.cc View 5 chunks +5 lines, -3 lines 0 comments Download
M media/mojo/services/renderer_config.h View 3 chunks +2 lines, -4 lines 0 comments Download
M media/mojo/services/renderer_config.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M media/mojo/services/renderer_config_default.cc View 2 chunks +0 lines, -18 lines 0 comments Download
M media/renderers/default_renderer_factory.h View 2 chunks +1 line, -3 lines 0 comments Download
M media/renderers/default_renderer_factory.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M media/renderers/renderer_impl.h View 2 chunks +2 lines, -0 lines 0 comments Download
M media/renderers/renderer_impl.cc View 4 chunks +4 lines, -0 lines 0 comments Download
M media/renderers/renderer_impl_unittest.cc View 4 chunks +7 lines, -4 lines 0 comments Download
M media/renderers/video_renderer_impl.h View 6 chunks +1 line, -10 lines 0 comments Download
M media/renderers/video_renderer_impl.cc View 5 chunks +3 lines, -17 lines 0 comments Download
M media/renderers/video_renderer_impl_unittest.cc View 15 chunks +18 lines, -27 lines 0 comments Download
M media/test/pipeline_integration_test.cc View 3 chunks +9 lines, -1 line 0 comments Download
M media/test/pipeline_integration_test_base.h View 2 chunks +0 lines, -15 lines 0 comments Download
M media/test/pipeline_integration_test_base.cc View 4 chunks +3 lines, -9 lines 0 comments Download
A media/tools/player_x11/data_source_logger.h View 1 chunk +41 lines, -0 lines 0 comments Download
A media/tools/player_x11/data_source_logger.cc View 1 chunk +59 lines, -0 lines 0 comments Download
A media/tools/player_x11/gl_video_renderer.h View 1 chunk +43 lines, -0 lines 0 comments Download
A media/tools/player_x11/gl_video_renderer.cc View 1 chunk +251 lines, -0 lines 0 comments Download
A media/tools/player_x11/player_x11.cc View 1 chunk +311 lines, -0 lines 0 comments Download
A media/tools/player_x11/x11_video_renderer.h View 1 chunk +47 lines, -0 lines 0 comments Download
A media/tools/player_x11/x11_video_renderer.cc View 1 chunk +215 lines, -0 lines 0 comments Download
M net/url_request/url_fetcher_impl_unittest.cc View 4 chunks +173 lines, -107 lines 0 comments Download
M net/url_request/url_request_test_util.h View 1 chunk +1 line, -2 lines 0 comments Download
M sync/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M sync/test/fake_server/android/fake_server_helper_android.h View 2 chunks +0 lines, -15 lines 0 comments Download
M sync/test/fake_server/android/fake_server_helper_android.cc View 2 chunks +0 lines, -41 lines 0 comments Download
M sync/test/fake_server/bookmark_entity_builder.h View 2 chunks +0 lines, -7 lines 0 comments Download
M sync/test/fake_server/bookmark_entity_builder.cc View 3 chunks +4 lines, -9 lines 0 comments Download
M sync/test/fake_server/fake_server.h View 2 chunks +4 lines, -6 lines 0 comments Download
M sync/test/fake_server/fake_server.cc View 6 chunks +23 lines, -39 lines 0 comments Download
M tools/mb/mb_config.pyl View 3 chunks +6 lines, -8 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 chunk +0 lines, -9 lines 0 comments Download
M tools/run-bisect-perf-regression.py View 2 chunks +1 line, -3 lines 0 comments Download
M ui/compositor/layer.h View 1 chunk +1 line, -2 lines 0 comments Download
M ui/compositor/layer.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ui/file_manager/file_manager/foreground/css/cws_widget_container.css View 1 chunk +0 lines, -17 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/compiled_resources.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M ui/file_manager/file_manager/foreground/js/cws_widget_container.js View 4 chunks +2 lines, -13 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/main_scripts.js View 1 chunk +0 lines, -1 line 0 comments Download
D ui/file_manager/file_manager/foreground/js/ui/cws_widget_container_error_dialog.js View 1 chunk +0 lines, -58 lines 0 comments Download
M ui/file_manager/file_manager/main.html View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/919dce4400651813d5ff6e8a85b944a5987adcb7 Cr-Commit-Position: refs/heads/master@{#325411}
5 years, 8 months ago (2015-04-16 10:13:11 UTC) #1
bartfab (slow)
Committed patchset #2 (id:20001) manually as 919dce4400651813d5ff6e8a85b944a5987adcb7 (tree was closed).
5 years, 8 months ago (2015-04-16 10:13:24 UTC) #2
Lei Zhang
I know sheriffs usually shoot and ask questions later, but a massive revert like this ...
5 years, 8 months ago (2015-04-20 21:01:50 UTC) #3
bartfab (slow)
5 years, 8 months ago (2015-04-21 08:45:18 UTC) #4
Message was sent while issue was closed.
On 2015/04/20 21:01:50, Lei Zhang wrote:
> I know sheriffs usually shoot and ask questions later, but a massive revert
like
> this is going a bit over the top. Did you notify the authors of all the
reverted
> CLs? Did you ever figure out who was actually to blame for the failures?

I did not need to notify anyone because I immediately reverted the revert:

https://codereview.chromium.org/1094553002

This revert was necessary because one of the 19 CLs caused breakage on the
Android bots and neither I nor the troopers could figure out which one. The
breakage happened on waterfall bots only, so the plan was to do a series of
speculative reverts/re-lands to bisect and figure out the broken commit. Just as
I was starting this process, an Android developer jumped in with more
information and we figured out the offending CL. Thus, I was able to quickly
reland.

Powered by Google App Engine
This is Rietveld 408576698