tools/run-bisect-perf-regression.py - Issue 1083683003: Speculative revert by sheriff

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/run-bisect-perf-regression.py

Issue 1083683003: Speculative revert by sheriff (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed an unrelated commit that had accidentally slipped in. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/run-bisect-perf-regression.py

diff --git a/tools/run-bisect-perf-regression.py b/tools/run-bisect-perf-regression.py

index a9c7e54938110f89ad0c83c67535865c9a19aa09..dda359b9b40c698cf142b2c93d72c25e8f623622 100755

--- a/tools/run-bisect-perf-regression.py

+++ b/tools/run-bisect-perf-regression.py

@@ -37,7 +37,6 @@ WEBKIT_RUN_TEST_CONFIG_PATH = os.path.join(

BISECT_SCRIPT_DIR = os.path.join(SCRIPT_DIR, 'auto_bisect')

PERF_BENCHMARKS_PATH = 'tools/perf/benchmarks'

-PERF_MEASUREMENTS_PATH = 'tools/perf/measurements'

BUILDBOT_BUILDERNAME = 'BUILDBOT_BUILDERNAME'

BENCHMARKS_JSON_FILE = 'benchmarks.json'

@@ -635,8 +634,7 @@ def _GetAffectedBenchmarkModuleNames():

all_affected_files = _GetModifiedFilesFromPatch()

modified_benchmarks = []

for affected_file in all_affected_files:

- if (affected_file.startswith(PERF_BENCHMARKS_PATH) or

- affected_file.startswith(PERF_MEASUREMENTS_PATH)):

+ if affected_file.startswith(PERF_BENCHMARKS_PATH):

benchmark = os.path.basename(os.path.splitext(affected_file)[0])

modified_benchmarks.append(benchmark)

return modified_benchmarks

« no previous file with comments | « tools/metrics/histograms/histograms.xml ('k') | ui/compositor/layer.h » ('j') | no next file with comments »