content/child/notifications/notification_data_conversions.cc - Issue 1083683003: Speculative revert by sheriff

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/notifications/notification_data_conversions.cc

Issue 1083683003: Speculative revert by sheriff (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed an unrelated commit that had accidentally slipped in. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/child/notifications/notification_data_conversions.cc

diff --git a/content/child/notifications/notification_data_conversions.cc b/content/child/notifications/notification_data_conversions.cc

index 639e55523088e68b957b92cb54fe7b9f8e00dbe7..a1b81289e18b3a034ccc870eb439501dea78cf2e 100644

--- a/content/child/notifications/notification_data_conversions.cc

+++ b/content/child/notifications/notification_data_conversions.cc

@@ -25,7 +25,6 @@ PlatformNotificationData ToPlatformNotificationData(

platform_data.tag = base::UTF16ToUTF8(web_data.tag);

platform_data.icon = GURL(web_data.icon.string());

platform_data.silent = web_data.silent;

- platform_data.data.assign(web_data.data.begin(), web_data.data.end());

return platform_data;

}

@@ -44,7 +43,6 @@ WebNotificationData ToWebNotificationData(

web_data.tag = blink::WebString::fromUTF8(platform_data.tag);

web_data.icon = blink::WebURL(platform_data.icon);

web_data.silent = platform_data.silent;

- web_data.data = platform_data.data;

return web_data;

}