Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: media/base/video_renderer_sink.h

Issue 1083683003: Speculative revert by sheriff (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Removed an unrelated commit that had accidentally slipped in. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/base/video_renderer.h ('k') | media/base/wall_clock_time_source.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/base/video_renderer_sink.h
diff --git a/media/base/video_renderer_sink.h b/media/base/video_renderer_sink.h
deleted file mode 100644
index a2852ffcae575e6e2008fa6503ef79a4db541893..0000000000000000000000000000000000000000
--- a/media/base/video_renderer_sink.h
+++ /dev/null
@@ -1,64 +0,0 @@
-// Copyright 2015 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef MEDIA_BASE_VIDEO_RENDERER_SINK_H_
-#define MEDIA_BASE_VIDEO_RENDERER_SINK_H_
-
-#include "base/basictypes.h"
-#include "base/logging.h"
-#include "base/memory/ref_counted.h"
-#include "base/time/time.h"
-#include "media/base/media_export.h"
-#include "media/base/video_frame.h"
-
-namespace media {
-
-// VideoRendererSink is an interface representing the end-point for rendered
-// video frames. An implementation is expected to periodically call Render() on
-// a callback object.
-class MEDIA_EXPORT VideoRendererSink {
- public:
- class RenderCallback {
- public:
- // Returns a VideoFrame for rendering which should be displayed within the
- // presentation interval [|deadline_min|, |deadline_max|]. Returns NULL if
- // no frame or no new frame (since the last Render() call) is available for
- // rendering within the requested interval. Intervals are expected to be
- // regular, contiguous, and monotonically increasing. Irregular intervals
- // may affect the rendering decisions made by the underlying callback.
- virtual scoped_refptr<VideoFrame> Render(base::TimeTicks deadline_min,
- base::TimeTicks deadline_max) = 0;
-
- // Called by the sink when a VideoFrame previously returned via Render() was
- // not actually rendered. Must be called before the next Render() call.
- virtual void OnFrameDropped() = 0;
-
- virtual ~RenderCallback() {}
- };
-
- // Starts video rendering. See RenderCallback for more details. Must be
- // called to receive Render() callbacks. Callbacks may start immediately, so
- // |callback| must be ready to receive callbacks before calling Start().
- virtual void Start(RenderCallback* callback) = 0;
-
- // Stops video rendering, waits for any outstanding calls to the |callback|
- // given to Start() to complete before returning. No new calls to |callback|
- // will be issued after this method returns. May be used as a means of power
- // conservation by the sink implementation, so clients should call this
- // liberally if no new frames are expected.
- virtual void Stop() = 0;
-
- // Instead of using a callback driven rendering path, allow clients to paint
- // frames as they see fit without regard for the compositor.
- // TODO(dalecurtis): This should be nuked once experiments show the new path
- // is amazing and the old path is not! http://crbug.com/439548
- virtual void PaintFrameUsingOldRenderingPath(
- const scoped_refptr<VideoFrame>& frame) = 0;
-
- virtual ~VideoRendererSink() {}
-};
-
-} // namespace media
-
-#endif // MEDIA_BASE_VIDEO_RENDERER_SINK_H_
« no previous file with comments | « media/base/video_renderer.h ('k') | media/base/wall_clock_time_source.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698