media/mojo/services/mojo_renderer_impl.cc - Issue 1083683003: Speculative revert by sheriff

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/mojo/services/mojo_renderer_impl.cc

Issue 1083683003: Speculative revert by sheriff (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed an unrelated commit that had accidentally slipped in. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/mojo/services/mojo_renderer_impl.cc

diff --git a/media/mojo/services/mojo_renderer_impl.cc b/media/mojo/services/mojo_renderer_impl.cc

index d1b41a6dd2257703d7750a36cfef45f28609be4c..e4a133261579296415cda12d4a304d653473c79c 100644

--- a/media/mojo/services/mojo_renderer_impl.cc

+++ b/media/mojo/services/mojo_renderer_impl.cc

@@ -33,12 +33,14 @@ MojoRendererImpl::~MojoRendererImpl() {

// Connection to |remote_media_renderer_| will error-out here.

}

-// TODO(xhwang): Support |waiting_for_decryption_key_cb| if needed.

+// TODO(xhwang): Support |paint_cb| and |waiting_for_decryption_key_cb|,

+// if needed.

void MojoRendererImpl::Initialize(

DemuxerStreamProvider* demuxer_stream_provider,

const PipelineStatusCB& init_cb,

const StatisticsCB& statistics_cb,

const BufferingStateCB& buffering_state_cb,

+ const PaintCB& /* paint_cb */,

const base::Closure& ended_cb,

const PipelineStatusCB& error_cb,

const base::Closure& /* waiting_for_decryption_key_cb */) {