Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(780)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1049873005: [chrome/browser/chromeos/] favor DCHECK_CURRENTLY_ON for better logs (Closed)

Created:
5 years, 8 months ago by anujsharma
Modified:
5 years, 8 months ago
Reviewers:
oshima
CC:
chromium-reviews, Mostyn Bramley-Moore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

favor DCHECK_CURRENTLY_ON for better logs in left out chrome/browser/chromeos/ BUG=466848 Committed: https://crrev.com/14ccb93f5f75f388b6a6b4a9c1eb434f61dbbfef Cr-Commit-Position: refs/heads/master@{#326439}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -53 lines) Patch
M chrome/browser/chromeos/app_mode/certificate_manager_dialog.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/attestation/attestation_policy_observer.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/attestation/platform_verification_flow.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/base/locale_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/customization/customization_wallpaper_downloader.cc View 5 chunks +8 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/drive/file_task_executor.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/first_run/drive_first_run_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screens/network_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/screenshot_testing/screenshot_tester.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/session/user_session_manager.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/ui/proxy_settings_dialog.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/mobile/mobile_activator.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/policy/policy_cert_verifier.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/power/cpu_data_collector.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/power/peripheral_battery_observer.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/settings/cros_settings_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/settings/device_oauth2_token_service_factory.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/system/input_device_settings_impl_ozone.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/system/input_device_settings_impl_x11.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/system_logs/dbus_log_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/system_logs/debug_daemon_log_source.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/system_logs/device_event_log_source.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
anujsharma
PTAL
5 years, 8 months ago (2015-04-21 09:43:35 UTC) #2
oshima
lgtm
5 years, 8 months ago (2015-04-22 22:05:21 UTC) #3
anujsharma
On 2015/04/22 22:05:21, oshima wrote: > lgtm Thanks oshima for lgtm.
5 years, 8 months ago (2015-04-23 02:10:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1049873005/1
5 years, 8 months ago (2015-04-23 02:11:34 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-23 03:08:12 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-04-23 03:09:11 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/14ccb93f5f75f388b6a6b4a9c1eb434f61dbbfef
Cr-Commit-Position: refs/heads/master@{#326439}

Powered by Google App Engine
This is Rietveld 408576698