chrome/browser/chromeos/mobile/mobile_activator.cc - Issue 1049873005: [chrome/browser/chromeos/] favor DCHECK_CURRENTLY_ON for better logs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/mobile/mobile_activator.cc

Issue 1049873005: [chrome/browser/chromeos/] favor DCHECK_CURRENTLY_ON for better logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/ui/proxy_settings_dialog.cc ('k') | chrome/browser/chromeos/policy/policy_cert_verifier.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/mobile/mobile_activator.cc

diff --git a/chrome/browser/chromeos/mobile/mobile_activator.cc b/chrome/browser/chromeos/mobile/mobile_activator.cc

index 73b5d445a3212d96fbcac75b6c51a066e23accdd..02b0b534e02683cb0d14811aeb49904d09930e38 100644

--- a/chrome/browser/chromeos/mobile/mobile_activator.cc

+++ b/chrome/browser/chromeos/mobile/mobile_activator.cc

@@ -239,17 +239,17 @@ void MobileActivator::NetworkPropertiesUpdated(const NetworkState* network) {

}

void MobileActivator::AddObserver(MobileActivator::Observer* observer) {

- DCHECK(content::BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

observers_.AddObserver(observer);

}

void MobileActivator::RemoveObserver(MobileActivator::Observer* observer) {

- DCHECK(content::BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

observers_.RemoveObserver(observer);

}

void MobileActivator::InitiateActivation(const std::string& service_path) {

- DCHECK(content::BrowserThread::CurrentlyOn(BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(BrowserThread::UI);

const NetworkState* network = GetNetworkState(service_path);

if (!network) {

LOG(WARNING) << "Cellular service can't be found: " << service_path;