chrome/browser/chromeos/base/locale_util.cc - Issue 1049873005: [chrome/browser/chromeos/] favor DCHECK_CURRENTLY_ON for better logs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/base/locale_util.cc

Issue 1049873005: [chrome/browser/chromeos/] favor DCHECK_CURRENTLY_ON for better logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/attestation/platform_verification_flow.cc ('k') | chrome/browser/chromeos/customization/customization_wallpaper_downloader.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/base/locale_util.cc

diff --git a/chrome/browser/chromeos/base/locale_util.cc b/chrome/browser/chromeos/base/locale_util.cc

index c185d78da4dc5299484e3a23bdc78df9a1cef30e..37e659b348b93b50ddb7c7699a3ed53b60b69b3b 100644

--- a/chrome/browser/chromeos/base/locale_util.cc

+++ b/chrome/browser/chromeos/base/locale_util.cc

@@ -50,7 +50,7 @@ void SwitchLanguageDoReloadLocale(SwitchLanguageData* data) {

// Callback after SwitchLanguageDoReloadLocale() back in UI thread.

void FinishSwitchLanguage(scoped_ptr<SwitchLanguageData> data) {

- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

if (data->result.success) {

g_browser_process->SetApplicationLocale(data->result.loaded_locale);

@@ -107,7 +107,7 @@ void SwitchLanguage(const std::string& locale,

const bool enable_locale_keyboard_layouts,

const bool login_layouts_only,

const SwitchLanguageCallback& callback) {

- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

scoped_ptr<SwitchLanguageData> data(new SwitchLanguageData(

locale, enable_locale_keyboard_layouts, login_layouts_only, callback));

base::Closure reloader(