chrome/browser/chromeos/login/ui/proxy_settings_dialog.cc - Issue 1049873005: [chrome/browser/chromeos/] favor DCHECK_CURRENTLY_ON for better logs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/ui/proxy_settings_dialog.cc

Issue 1049873005: [chrome/browser/chromeos/] favor DCHECK_CURRENTLY_ON for better logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/login/supervised/supervised_user_creation_screen.cc ('k') | chrome/browser/chromeos/mobile/mobile_activator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/ui/proxy_settings_dialog.cc

diff --git a/chrome/browser/chromeos/login/ui/proxy_settings_dialog.cc b/chrome/browser/chromeos/login/ui/proxy_settings_dialog.cc

index a91b2e3b3d71dae381300ae4b0e89d7f9d540eeb..7bb0765ca87362ba5db04054ba422b1df748d65a 100644

--- a/chrome/browser/chromeos/login/ui/proxy_settings_dialog.cc

+++ b/chrome/browser/chromeos/login/ui/proxy_settings_dialog.cc

@@ -62,7 +62,7 @@ ProxySettingsDialog::ProxySettingsDialog(

window,

base::string16(),

GetURLForProxySettings(network.guid())) {

- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

++instance_count_;

gfx::Rect screen_bounds(chromeos::CalculateScreenBounds(gfx::Size()));

@@ -84,7 +84,7 @@ ProxySettingsDialog::ProxySettingsDialog(

}

ProxySettingsDialog::~ProxySettingsDialog() {

- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

--instance_count_;

}