chrome/browser/chromeos/drive/file_task_executor.cc - Issue 1049873005: [chrome/browser/chromeos/] favor DCHECK_CURRENTLY_ON for better logs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/drive/file_task_executor.cc

Issue 1049873005: [chrome/browser/chromeos/] favor DCHECK_CURRENTLY_ON for better logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/customization/customization_wallpaper_downloader.cc ('k') | chrome/browser/chromeos/first_run/drive_first_run_controller.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/drive/file_task_executor.cc

diff --git a/chrome/browser/chromeos/drive/file_task_executor.cc b/chrome/browser/chromeos/drive/file_task_executor.cc

index b91fc3a90b07cea46835f5a6e7ce8397683cc2cf..eb799a2ec184eab30365db07995eb1a737ded252 100644

--- a/chrome/browser/chromeos/drive/file_task_executor.cc

+++ b/chrome/browser/chromeos/drive/file_task_executor.cc

@@ -136,7 +136,7 @@ void FileTaskExecutor::OnFileEntryFetched(FileError error,

void FileTaskExecutor::OnAppAuthorized(const std::string& resource_id,

google_apis::DriveApiErrorCode error,

const GURL& open_link) {

- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

if (error != google_apis::HTTP_SUCCESS || open_link.is_empty()) {

Done(false);

@@ -153,7 +153,7 @@ void FileTaskExecutor::OnAppAuthorized(const std::string& resource_id,

}

void FileTaskExecutor::Done(bool success) {

- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

if (!done_.is_null())

done_.Run(success

? extensions::api::file_manager_private::TASK_RESULT_OPENED