chrome/browser/chromeos/attestation/attestation_policy_observer.cc - Issue 1049873005: [chrome/browser/chromeos/] favor DCHECK_CURRENTLY_ON for better logs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/attestation/attestation_policy_observer.cc

Issue 1049873005: [chrome/browser/chromeos/] favor DCHECK_CURRENTLY_ON for better logs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/app_mode/certificate_manager_dialog.cc ('k') | chrome/browser/chromeos/attestation/platform_verification_flow.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/attestation/attestation_policy_observer.cc

diff --git a/chrome/browser/chromeos/attestation/attestation_policy_observer.cc b/chrome/browser/chromeos/attestation/attestation_policy_observer.cc

index ee8d5de3765ae5914185d9c6a3d02c39c4f315ae..138d8b095a86bbde7ad8fb07c51cb3cd5b12f6b5 100644

--- a/chrome/browser/chromeos/attestation/attestation_policy_observer.cc

+++ b/chrome/browser/chromeos/attestation/attestation_policy_observer.cc

@@ -99,7 +99,7 @@ AttestationPolicyObserver::AttestationPolicyObserver(

num_retries_(0),

retry_delay_(kRetryDelay),

weak_factory_(this) {

- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

attestation_subscription_ = cros_settings_->AddSettingsObserver(

kDeviceAttestationEnabled,

base::Bind(&AttestationPolicyObserver::AttestationSettingChanged,

@@ -118,7 +118,7 @@ AttestationPolicyObserver::AttestationPolicyObserver(

num_retries_(0),

retry_delay_(kRetryDelay),

weak_factory_(this) {

- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

attestation_subscription_ = cros_settings_->AddSettingsObserver(

kDeviceAttestationEnabled,

base::Bind(&AttestationPolicyObserver::AttestationSettingChanged,

@@ -127,7 +127,7 @@ AttestationPolicyObserver::AttestationPolicyObserver(

}

AttestationPolicyObserver::~AttestationPolicyObserver() {

- DCHECK(content::BrowserThread::CurrentlyOn(content::BrowserThread::UI));

+ DCHECK_CURRENTLY_ON(content::BrowserThread::UI);

}

void AttestationPolicyObserver::AttestationSettingChanged() {