[Sync] Replace AttachmentIdSet with AttachmentIdList in interfaces.

[Sync] Replace AttachmentIdSet with AttachmentIdList in interfaces.

Today both types are used on AttachmentService and other interfaces.
In this change I make all interfaces use AttachmentIdList.
AttachmentIdSet is only used in implementations and unittests.

R=maniscalco@chromium.org
BUG=
TEST=No observable behavior change.

Committed: https://crrev.com/66175b0031526dd7d2575b6bcce62a1c5c2db580
Cr-Commit-Position: refs/heads/master@{#322130}

[maniscalco, 2015-03-25 00:42:39]

Nice work.  Thanks for cleaning this up.  LGTM modulo the items below.

https://codereview.chromium.org/1035573002/diff/1/sync/internal_api/attachmen...
File sync/internal_api/attachments/attachment_service_impl.cc (right):

https://codereview.chromium.org/1035573002/diff/1/sync/internal_api/attachmen...
sync/internal_api/attachments/attachment_service_impl.cc:281: for (auto iter =
attachment_ids.begin(); iter != attachment_ids.end();
Oooh, fancy.

https://codereview.chromium.org/1035573002/diff/1/sync/internal_api/attachmen...
File sync/internal_api/attachments/attachment_service_impl_unittest.cc (right):

https://codereview.chromium.org/1035573002/diff/1/sync/internal_api/attachmen...
sync/internal_api/attachments/attachment_service_impl_unittest.cc:263:
AttachmentIdSet AttachmentIdSetFromList(const AttachmentIdList& id_list) {
Could be static?

https://codereview.chromium.org/1035573002/diff/1/sync/internal_api/attachmen...
sync/internal_api/attachments/attachment_service_impl_unittest.cc:472:
std::copy(attachment_ids.begin(), attachment_ids.end(),
Can you use AttachmentIdSetFromList here?

[pavely, 2015-03-25 00:51:56]

The CQ bit was checked by pavely@chromium.org

[pavely, 2015-03-25 00:51:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
maniscalco@chromium.org
Link to the patchset: https://codereview.chromium.org/1035573002/#ps20001
(title: "Changes after Nick's feedback.")

[pavely, 2015-03-25 00:52:11]

https://codereview.chromium.org/1035573002/diff/1/sync/internal_api/attachmen...
File sync/internal_api/attachments/attachment_service_impl_unittest.cc (right):

https://codereview.chromium.org/1035573002/diff/1/sync/internal_api/attachmen...
sync/internal_api/attachments/attachment_service_impl_unittest.cc:263:
AttachmentIdSet AttachmentIdSetFromList(const AttachmentIdList& id_list) {
On 2015/03/25 00:42:39, maniscalco wrote:
> Could be static?

Done.

https://codereview.chromium.org/1035573002/diff/1/sync/internal_api/attachmen...
sync/internal_api/attachments/attachment_service_impl_unittest.cc:472:
std::copy(attachment_ids.begin(), attachment_ids.end(),
On 2015/03/25 00:42:39, maniscalco wrote:
> Can you use AttachmentIdSetFromList here?

Done.

[commit-bot: I haz the power, 2015-03-25 00:52:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1035573002/20001

[commit-bot: I haz the power, 2015-03-25 03:24:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-25 03:24:25]

Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pavely, 2015-03-25 04:25:28]

The CQ bit was checked by pavely@chromium.org

[commit-bot: I haz the power, 2015-03-25 04:26:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1035573002/20001

[commit-bot: I haz the power, 2015-03-25 07:44:54]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-25 07:45:27]

Patchset 2 (id:??) landed as
https://crrev.com/66175b0031526dd7d2575b6bcce62a1c5c2db580
Cr-Commit-Position: refs/heads/master@{#322130}