sync/internal_api/attachments/attachment_service_proxy_unittest.cc - Issue 1035573002: [Sync] Replace AttachmentIdSet with AttachmentIdList in interfaces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/attachments/attachment_service_proxy_unittest.cc

Issue 1035573002: [Sync] Replace AttachmentIdSet with AttachmentIdList in interfaces. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes after Nick's feedback. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sync/internal_api/attachments/attachment_service_proxy.cc ('k') | sync/internal_api/public/attachments/attachment_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/internal_api/attachments/attachment_service_proxy_unittest.cc

diff --git a/sync/internal_api/attachments/attachment_service_proxy_unittest.cc b/sync/internal_api/attachments/attachment_service_proxy_unittest.cc

index a66b39f4858fc278c327bab10a694319a529e5d2..fe52f469fba7881ab5211397d976ba6d4dfc6ae7 100644

--- a/sync/internal_api/attachments/attachment_service_proxy_unittest.cc

+++ b/sync/internal_api/attachments/attachment_service_proxy_unittest.cc

@@ -46,7 +46,7 @@ class StubAttachmentService : public AttachmentService,

base::Passed(&attachments)));

}

- void UploadAttachments(const AttachmentIdSet& attachments_ids) override {

+ void UploadAttachments(const AttachmentIdList& attachments_ids) override {

CalledOnValidThread();

Increment();

}

@@ -135,7 +135,7 @@ class AttachmentServiceProxyTest : public testing::Test,

// thread.

TEST_F(AttachmentServiceProxyTest, MethodsAreProxied) {

proxy->GetOrDownloadAttachments(AttachmentIdList(), callback_get_or_download);

- proxy->UploadAttachments(AttachmentIdSet());

+ proxy->UploadAttachments(AttachmentIdList());

// Wait for the posted calls to execute in the stub thread.

WaitForStubThread();

EXPECT_EQ(2, stub->GetCallCount());