sync/api/attachments/attachment_id.h - Issue 1035573002: [Sync] Replace AttachmentIdSet with AttachmentIdList in interfaces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/api/attachments/attachment_id.h

Issue 1035573002: [Sync] Replace AttachmentIdSet with AttachmentIdList in interfaces. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes after Nick's feedback. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sync_driver/generic_change_processor_unittest.cc ('k') | sync/internal_api/attachments/attachment_service_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/api/attachments/attachment_id.h

diff --git a/sync/api/attachments/attachment_id.h b/sync/api/attachments/attachment_id.h

index 1c53355f8c476acb2fd81267eedd378c7582c9ea..039d38684d9927a14a9d76513e5a76f7ccab4e3d 100644

--- a/sync/api/attachments/attachment_id.h

+++ b/sync/api/attachments/attachment_id.h

@@ -75,6 +75,8 @@ class SYNC_EXPORT AttachmentId {

AttachmentId(sync_pb::AttachmentIdProto* proto);

};

+// All public interfaces use AttachmentIdList. AttachmentIdSet is used in

+// implementations of algorithms where set properties are needed.

typedef std::vector<AttachmentId> AttachmentIdList;

typedef std::set<AttachmentId> AttachmentIdSet;