sync/internal_api/read_transaction.cc - Issue 1035573002: [Sync] Replace AttachmentIdSet with AttachmentIdList in interfaces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/read_transaction.cc

Issue 1035573002: [Sync] Replace AttachmentIdSet with AttachmentIdList in interfaces. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes after Nick's feedback. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sync/internal_api/read_transaction.cc

diff --git a/sync/internal_api/read_transaction.cc b/sync/internal_api/read_transaction.cc

index 872818fb3b4fb89723afc3aaf78adb0bdd7808b3..9d81b0e4c4d30817148bd223018d470d7356a99b 100644

--- a/sync/internal_api/read_transaction.cc

+++ b/sync/internal_api/read_transaction.cc

@@ -48,10 +48,9 @@ void ReadTransaction::GetDataTypeContext(

}

void ReadTransaction::GetAttachmentIdsToUpload(ModelType type,

- AttachmentIdSet* id_set) const {

- DCHECK(id_set);

- transaction_->directory()->GetAttachmentIdsToUpload(

- transaction_, type, id_set);

+ AttachmentIdList* ids) const {

+ DCHECK(ids);

+ transaction_->directory()->GetAttachmentIdsToUpload(transaction_, type, ids);

}

std::string ReadTransaction::GetStoreBirthday() const {

« no previous file with comments | « sync/internal_api/public/read_transaction.h ('k') | sync/syncable/directory.h » ('j') | no next file with comments »