Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1026)

Unified Diff: sync/syncable/directory_unittest.cc

Issue 1035573002: [Sync] Replace AttachmentIdSet with AttachmentIdList in interfaces. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Changes after Nick's feedback. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sync/syncable/directory.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sync/syncable/directory_unittest.cc
diff --git a/sync/syncable/directory_unittest.cc b/sync/syncable/directory_unittest.cc
index 5f8cbed23c2225e3827f09a905586f6f8e4eaa5a..fecfaca2321cc9d684e67ed34813f93332617d7b 100644
--- a/sync/syncable/directory_unittest.cc
+++ b/sync/syncable/directory_unittest.cc
@@ -1784,21 +1784,21 @@ TEST_F(SyncableDirectoryTest, Directory_GetAttachmentIdsToUpload) {
PREFERENCES, "some other entry", id2, attachment_metadata);
// See that Directory reports that this attachment is not on the server.
- AttachmentIdSet id_set;
+ AttachmentIdList ids;
{
ReadTransaction trans(FROM_HERE, dir().get());
- dir()->GetAttachmentIdsToUpload(&trans, PREFERENCES, &id_set);
+ dir()->GetAttachmentIdsToUpload(&trans, PREFERENCES, &ids);
}
- ASSERT_EQ(1U, id_set.size());
- ASSERT_EQ(attachment_id, *id_set.begin());
+ ASSERT_EQ(1U, ids.size());
+ ASSERT_EQ(attachment_id, *ids.begin());
// Call again, but this time with a ModelType for which there are no entries.
// See that Directory correctly reports that there are none.
{
ReadTransaction trans(FROM_HERE, dir().get());
- dir()->GetAttachmentIdsToUpload(&trans, PASSWORDS, &id_set);
+ dir()->GetAttachmentIdsToUpload(&trans, PASSWORDS, &ids);
}
- ASSERT_TRUE(id_set.empty());
+ ASSERT_TRUE(ids.empty());
// Now, mark the attachment as "on the server" via entry_1.
{
@@ -1811,9 +1811,9 @@ TEST_F(SyncableDirectoryTest, Directory_GetAttachmentIdsToUpload) {
// server.
{
ReadTransaction trans(FROM_HERE, dir().get());
- dir()->GetAttachmentIdsToUpload(&trans, PREFERENCES, &id_set);
+ dir()->GetAttachmentIdsToUpload(&trans, PREFERENCES, &ids);
}
- ASSERT_TRUE(id_set.empty());
+ ASSERT_TRUE(ids.empty());
}
// Verify that the directory accepts entries with unset parent ID.
« no previous file with comments | « sync/syncable/directory.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698