sync/internal_api/public/attachments/attachment_service_impl.h - Issue 1035573002: [Sync] Replace AttachmentIdSet with AttachmentIdList in interfaces.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/public/attachments/attachment_service_impl.h

Issue 1035573002: [Sync] Replace AttachmentIdSet with AttachmentIdList in interfaces. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Changes after Nick's feedback. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sync/internal_api/public/attachments/attachment_service.h ('k') | sync/internal_api/public/attachments/attachment_service_proxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sync/internal_api/public/attachments/attachment_service_impl.h

diff --git a/sync/internal_api/public/attachments/attachment_service_impl.h b/sync/internal_api/public/attachments/attachment_service_impl.h

index c3275bffbf905133945b591b4e7cb524d2c56328..03d921f13e0f8798450931914bacc2e5edd689e8 100644

--- a/sync/internal_api/public/attachments/attachment_service_impl.h

+++ b/sync/internal_api/public/attachments/attachment_service_impl.h

@@ -64,7 +64,7 @@ class SYNC_EXPORT AttachmentServiceImpl

// AttachmentService implementation.

void GetOrDownloadAttachments(const AttachmentIdList& attachment_ids,

const GetOrDownloadCallback& callback) override;

- void UploadAttachments(const AttachmentIdSet& attachment_ids) override;

+ void UploadAttachments(const AttachmentIdList& attachment_ids) override;

// NetworkChangeObserver implementation.

void OnNetworkChanged(