Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 102843002: Move RemoveChars, ReplaceChars, TrimString, and TruncateUTF8ToByteSize to base namespace. (Closed)

Created:
7 years ago by brettw
Modified:
7 years ago
Reviewers:
viettrungluu
CC:
chromium-reviews, asanka, vandebo (ex-Chrome), aboxhall+watch_chromium.org, skanuj+watch_chromium.org, sadrul, nkostylev+watch_chromium.org, tzik, dhollowa+watch_chromium.org, dougw+watch_chromium.org, ilevy-cc_chromium.org, browser-components-watch_chromium.org, joi+watch-content_chromium.org, dmazzoni+watch_chromium.org, ajwong+watch_chromium.org, yfriedman+watch_chromium.org, kinuko+watch, native-client-reviews_googlegroups.com, stevenjb+watch_chromium.org, frankf+watch_chromium.org, tim+watch_chromium.org, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, benquan, melevin+watch_chromium.org, jar (doing other things), estade+watch_chromium.org, benjhayden+dwatch_chromium.org, Ilya Sherman, kkania, dyu1, jam, dominich, darin-cc_chromium.org, rouslan+autofillwatch_chromium.org, chromium-apps-reviews_chromium.org, erikwright+watch_chromium.org, Dane Wallinga, dtseng+watch_chromium.org, Avi (use Gerrit), creis+watch_chromium.org, samarth+watch_chromium.org, yoshiki+watch_chromium.org, Paweł Hajdan Jr., haitaol+watch_chromium.org, craigdh+watch_chromium.org, nhiroki, jfweitz+watch_chromium.org, bulach+watch_chromium.org, yuzo+watch_chromium.org, oshima+watch_chromium.org, kalyank, piman+watch_chromium.org, Jered, chrome-apps-syd-reviews_chromium.org, rsimha+watch_chromium.org, plundblad+watch_chromium.org, Lei Zhang, tfarina, donnd+watch_chromium.org, frankf, mmenke, asvitkine+watch_chromium.org, tommycli, eroman, David Black, ben+ash_chromium.org, Greg Billock, grt+watch_chromium.org, kmadhusu+watch_chromium.org, klundberg+watch_chromium.org, James Su, jshin+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Move RemoveChars, ReplaceChars, TrimString, and TruncateUTF8ToByteSize to base namespace. BUG= R=viettrungluu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=238465

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -143 lines) Patch
M apps/shell_window.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M ash/system/user/tray_user.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M base/strings/string_util.h View 4 chunks +20 lines, -20 lines 0 comments Download
M base/strings/string_util.cc View 3 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_match.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/autocomplete/builtin_provider.cc View 1 chunk +2 lines, -1 line 0 comments Download
chrome/browser/bookmarks/bookmark_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/drive/file_system_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/hwid_checker.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/system/syslogs_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/component_updater/pnacl/pnacl_component_installer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/download/download_path_reservation_tracker.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/drive/fake_drive_service.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/networking_private/networking_private_crypto.cc View 1 chunk +1 line, -1 line 0 comments Download
chrome/browser/extensions/extension_context_menu_model.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/suspicious_extension_bubble_controller.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/suspicious_extension_bubble_controller_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/feedback/feedback_data.cc View 1 chunk +2 lines, -2 lines 0 comments Download
chrome/browser/guestview/adview/adview_guest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/guestview/webview/webview_guest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/fileapi/itunes_data_provider.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/linux/mtp_device_delegate_impl_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/media_galleries/win/mtp_device_delegate_impl_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/metrics/metrics_log.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/nacl_host/nacl_browser_delegate_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/password_manager/login_database.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/policy/cloud/resource_cache.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/profile_resetter/jtl_interpreter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/profile_resetter/resettable_settings_snapshot.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/safe_browsing/safe_browsing_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search/iframe_source.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/search_engines/template_url_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/shell_integration_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/gtk/gtk_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/net_internals/net_internals_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/version_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/web_app.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/web_applications/web_app_mac.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/localized_error.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/installer/setup/install.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/installer/util/shell_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/renderer/safe_browsing/phishing_url_feature_extractor.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/chromedriver/chrome/log.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/chrome_launcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/chromedriver/util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/ppapi/ppapi_test.cc View 1 chunk +8 lines, -8 lines 1 comment Download
M chrome/utility/importer/bookmark_html_reader.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/utility/media_galleries/iphoto_library_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chromeos/system/name_value_pairs_parser.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cloud_print/gcp20/prototype/printer.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/autofill_field.cc View 2 chunks +7 lines, -7 lines 0 comments Download
M components/autofill/core/browser/autofill_profile.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/credit_card.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/phone_number.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/validation.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/accessibility/dump_accessibility_tree_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_plugin/browser_plugin_guest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/gamepad/gamepad_platform_data_fetcher_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/common/page_state_serialization_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
content/public/common/webplugininfo.cc View 1 chunk +1 line, -1 line 0 comments Download
M dbus/message.cc View 1 chunk +1 line, -1 line 0 comments Download
M device/bluetooth/bluetooth_profile_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/cup/client_update_protocol.cc View 1 chunk +1 line, -1 line 0 comments Download
M google_apis/gaia/gaia_auth_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M gpu/config/gpu_info_collector_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M net/base/mime_util.cc View 1 chunk +1 line, -1 line 0 comments Download
net/base/net_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/ftp/ftp_network_transaction.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_network_transaction_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_resolver_v8.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/test/embedded_test_server/http_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/tools/gdig/gdig.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/engine/commit_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M sync/internal_api/write_node.cc View 1 chunk +1 line, -1 line 0 comments Download
M testing/android/native_test_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M tools/gn/ninja_script_target_writer.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/base/accelerators/menu_label_accelerator_util_linux.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/child/multipart_response_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M webkit/child/weburlloader_impl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
brettw
TBR=viettrungluu
7 years ago (2013-12-03 20:48:29 UTC) #1
viettrungluu
LGTM w/nit https://codereview.chromium.org/102843002/diff/1/chrome/test/ppapi/ppapi_test.cc File chrome/test/ppapi/ppapi_test.cc (right): https://codereview.chromium.org/102843002/diff/1/chrome/test/ppapi/ppapi_test.cc#newcode56 chrome/test/ppapi/ppapi_test.cc:56: } else { If you're going to ...
7 years ago (2013-12-03 21:13:42 UTC) #2
brettw
7 years ago (2013-12-03 22:05:37 UTC) #3
Message was sent while issue was closed. 
Committed patchset #1 manually as r238465.

Powered by Google App Engine
This is Rietveld 408576698