chrome/browser/extensions/suspicious_extension_bubble_controller_unittest.cc - Issue 102843002: Move RemoveChars, ReplaceChars, TrimString, and TruncateUTF8ToByteSize to base namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/suspicious_extension_bubble_controller_unittest.cc

Issue 102843002: Move RemoveChars, ReplaceChars, TrimString, and TruncateUTF8ToByteSize to base namespace. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/suspicious_extension_bubble_controller.cc ('k') | chrome/browser/feedback/feedback_data.cc » ('j') | chrome/test/ppapi/ppapi_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/suspicious_extension_bubble_controller_unittest.cc

diff --git a/chrome/browser/extensions/suspicious_extension_bubble_controller_unittest.cc b/chrome/browser/extensions/suspicious_extension_bubble_controller_unittest.cc

index 11b83d3d373c3f408826f99074375edf24b8826e..692079765fa53c69ae887d4ab4c5977b76b53b8c 100644

--- a/chrome/browser/extensions/suspicious_extension_bubble_controller_unittest.cc

+++ b/chrome/browser/extensions/suspicious_extension_bubble_controller_unittest.cc

@@ -137,21 +137,21 @@ TEST_F(SuspiciousExtensionBubbleTest, MAYBE_ControllerTest) {

"\"manifest_version\": 2}";

std::string extension_data;

- ReplaceChars(basic_extension, "#", "1", &extension_data);

+ base::ReplaceChars(basic_extension, "#", "1", &extension_data);

scoped_refptr<Extension> my_test_extension1(

CreateExtension(

Manifest::COMMAND_LINE,

extension_data,

"Autogenerated 1"));

- ReplaceChars(basic_extension, "#", "2", &extension_data);

+ base::ReplaceChars(basic_extension, "#", "2", &extension_data);

scoped_refptr<Extension> my_test_extension2(

CreateExtension(

Manifest::COMMAND_LINE,

extension_data,

"Autogenerated 2"));

- ReplaceChars(basic_extension, "#", "3", &extension_data);

+ base::ReplaceChars(basic_extension, "#", "3", &extension_data);

scoped_refptr<Extension> regular_extension(

CreateExtension(

Manifest::COMMAND_LINE,